gaia-ecs: new recipe #23080
Merged
gaia-ecs: new recipe #23080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
jwillikers
suggested changes
Mar 13, 2024
Comment on lines
9
to
11
| set(THREADS_PREFER_PTHREAD_FLAG ON) | ||
| find_package(Threads REQUIRED) | ||
| target_link_libraries(${PROJECT_NAME} PRIVATE Threads::Threads) |
There was a problem hiding this comment.
The fact that he test package isn't using threads directly indicates that something is missing in the package_info method. Perhaps:
if self.settings.os in ["FreeBSD", "Linux"]:
self.cpp_info.system_libs = ["pthread"]
This comment has been minimized.
This comment has been minimized.
jwillikers
approved these changes
Mar 14, 2024
conan-center-bot
added
Failed
Unexpected Error
and removed
Service Under Maintenance
labels
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
valgur
approved these changes
Mar 26, 2024
Conan v1 pipeline ✔️All green in build 5 (
Conan v2 pipeline ✔️
All green in build 5 (
|
jwillikers
approved these changes
Apr 16, 2024
uilianries
pushed a commit
to uilianries/conan-center-index
that referenced
this pull request
Aug 7, 2024
* gaia-ecs: new recipe * Add pthread * Remove threads from test cmakelists * Change to 0.8.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: gaia-ecs/0.8.5
Cmake target is named just "gaia" as per upstream's cmakelists