-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
util-linux-libuuid, make python bindings optional #23612
util-linux-libuuid, make python bindings optional #23612
Conversation
Minor comment, I would rename the option to avoid a negative, so There are some... issues with wanting to build them, as if you really wanted them then we should be using the CPython package, which would depend on this. There would probably have to be a chain: But that's a separate problem. I agree that if they were failing to be built anyways, then we shouldn't include them by default. |
…d_optionalize-python
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! My main concern here is that some people might be relying on having these by default - if this is fixing a specific configuration, maybe modifying the setting in the config_option
method in that case would work best?
@RubenRBS any news so far? It does not matter what is the default, i.e. on or off, but the option is definitely needed. |
This comment has been minimized.
This comment has been minimized.
ping |
This comment has been minimized.
This comment has been minimized.
@uilianries ping |
Hello @basiliscos! I'm currently on vacation 🌴, please, ping |
@ErniGH could you approve, please? |
Co-authored-by: Abril Rincón Blanco <git@rinconblanco.es>
Conan v1 pipeline ✔️Warning Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement. All green in build 5 (
Conan v2 pipeline ✔️
All green in build 5 ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks for your patience 😄
util-linux-libuuid/2.39.2
I hope this will fix the compilation in debug mode, see https://ci.appveyor.com/project/basiliscos/cpp-rotor/builds/49638104/job/2pg3xasvpoof4h8x
i.e. it find some old win32 python, while it is building in linux-on-windows, and than fails.