Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util-linux-libuuid, make python bindings optional #23612

Conversation

basiliscos
Copy link
Contributor

util-linux-libuuid/2.39.2

I hope this will fix the compilation in debug mode, see https://ci.appveyor.com/project/basiliscos/cpp-rotor/builds/49638104/job/2pg3xasvpoof4h8x

checking for ECONF... no
checking whether C:\Python38-x64 version is >= 2... no
configure: error: Python interpreter is too old
util-linux-libuuid/2.39.2: ERROR: 
Package '659f5046bee3c5a8463ca82f0ce7aaba50748d87' build failed

i.e. it find some old win32 python, while it is building in linux-on-windows, and than fails.


@Ahajha
Copy link
Contributor

Ahajha commented Apr 19, 2024

Minor comment, I would rename the option to avoid a negative, so with_python (or even better, with_python_bindings). Then if it's false, then set the flag.

There are some... issues with wanting to build them, as if you really wanted them then we should be using the CPython package, which would depend on this. There would probably have to be a chain:
Build context:
util-linux-libuuid (no bindings) -> cpython
Host context:
util-linux-libuuid (bindings)

But that's a separate problem. I agree that if they were failing to be built anyways, then we shouldn't include them by default.

@conan-center-bot

This comment has been minimized.

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! My main concern here is that some people might be relying on having these by default - if this is fixing a specific configuration, maybe modifying the setting in the config_option method in that case would work best?

@AbrilRBS AbrilRBS self-assigned this Apr 20, 2024
@basiliscos
Copy link
Contributor Author

@RubenRBS any news so far? It does not matter what is the default, i.e. on or off, but the option is definitely needed.

@conan-center-bot

This comment has been minimized.

@basiliscos
Copy link
Contributor Author

ping

@conan-center-bot

This comment has been minimized.

danimtb
danimtb previously approved these changes Sep 18, 2024
@basiliscos
Copy link
Contributor Author

@uilianries ping

@uilianries
Copy link
Member

Hello @basiliscos! I'm currently on vacation 🌴, please, ping @conan-io/barbarians for support. Have a nice day!

@basiliscos
Copy link
Contributor Author

@ErniGH could you approve, please?

Co-authored-by: Abril Rincón Blanco <git@rinconblanco.es>
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

Warning

Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement.

All green in build 5 (a8986a7bff99a1020fb229dae1c08027f83b72d5):

  • util-linux-libuuid/2.39.2:
    Built 16 packages out of 22 (All logs)

  • util-linux-libuuid/2.39:
    Built 16 packages out of 22 (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 5 (a8986a7bff99a1020fb229dae1c08027f83b72d5):

  • util-linux-libuuid/2.39.2:
    Built 6 packages out of 10 (All logs)

  • util-linux-libuuid/2.39:
    Built 6 packages out of 10 (All logs)

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@ErniGH ErniGH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks for your patience 😄

@conan-center-bot conan-center-bot merged commit 7522a12 into conan-io:master Oct 24, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants