Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure-sdk-for-cpp/1.11.3:new recipe #23663

Merged
merged 13 commits into from
Jul 11, 2024

Conversation

trns1997
Copy link
Contributor

@trns1997 trns1997 commented Apr 19, 2024

Add azure-sdk-for-cpp https://github.com/Azure/azure-sdk-for-cpp as the old azure-storage-cpp (homepage = "https://github.com/Azure/azure-storage-cpp) is deprecated (conan deprecated package: #18842). Also couple of users requested to add this package to conan: Azure/azure-sdk-for-cpp#5485

For the moment I mainly focused on building the entire sdk and only on Linux. Windows and apple not supported yet, contributions welcomed!


@CLAassistant
Copy link

CLAassistant commented Apr 19, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks a lot for your contribution, we appreciate it

I took a quick look, will be able to have a better review next monday, but for now I've found a few minor things worth commenting on :)

recipes/azure-sdk-for-cpp/all/conanfile.py Outdated Show resolved Hide resolved
recipes/azure-sdk-for-cpp/all/conanfile.py Outdated Show resolved Hide resolved
recipes/azure-sdk-for-cpp/all/test_package/CMakeLists.txt Outdated Show resolved Hide resolved
@AbrilRBS AbrilRBS self-assigned this Apr 20, 2024
@conan-center-bot

This comment has been minimized.

Copy link
Contributor

Hooks produced the following warnings for commit 34b5aba
azure-sdk-for-cpp/1.11.3@#39f2d59183bbaf2eaebdde682b37406a
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './sdk/eventhubs/azure-messaging-eventhubs-checkpointstore-blob/inc/azure/messaging/eventhubs/checkpointstore_blob/blob_checkpoint_store.hpp' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_package(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './share/azure-security-keyvault-certificates-cpp/azure-security-keyvault-certificates-cppConfig.cmake' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_package(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './share/azure-security-keyvault-administration-cpp/azure-security-keyvault-administration-cppConfig.cmake' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_package(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './share/azure-security-keyvault-secrets-cpp/azure-security-keyvault-secrets-cppTargets-release.cmake' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.

@conan-center-bot

This comment has been minimized.

@trns1997 trns1997 force-pushed the new/azure-sdk-for-cpp branch 2 times, most recently from 2c69930 to 79f8579 Compare April 20, 2024 07:56
@conan-center-bot

This comment has been minimized.

@trns1997 trns1997 force-pushed the new/azure-sdk-for-cpp branch from 4a01f69 to a7aabef Compare April 23, 2024 19:10
@conan-center-bot

This comment has been minimized.

Copy link
Contributor

Hooks produced the following warnings for commit a7aabef
azure-sdk-for-cpp/1.11.3@#d79345ae18633c2edb208e83b9fc4cc6
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './sdk/eventhubs/azure-messaging-eventhubs-checkpointstore-blob/inc/azure/messaging/eventhubs/checkpointstore_blob/blob_checkpoint_store.hpp' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_package(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './share/azure-security-keyvault-certificates-cpp/azure-security-keyvault-certificates-cppConfig.cmake' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_package(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './share/azure-security-keyvault-administration-cpp/azure-security-keyvault-administration-cppConfig.cmake' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_package(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './share/azure-security-keyvault-secrets-cpp/azure-security-keyvault-secrets-cppTargets-release.cmake' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

Hooks produced the following warnings for commit eec0523
azure-sdk-for-cpp/1.11.3@#46cda78c8d544deb347afa02a23b0ed7
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './sdk/eventhubs/azure-messaging-eventhubs-checkpointstore-blob/inc/azure/messaging/eventhubs/checkpointstore_blob/blob_checkpoint_store.hpp' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.

@trns1997 trns1997 requested a review from AbrilRBS April 26, 2024 14:38
@conan-center-bot

This comment has been minimized.

@trns1997
Copy link
Contributor Author

@RubenRBS I would like to get your inputs on this PR. I would like to install this package via Conan

@AbrilRBS
Copy link
Member

Hi @trns1997 , sorry for the delay, most of the team was attending a conference last week which delayed reviews a bit, will get back to you tomorrow :)

@trns1997
Copy link
Contributor Author

trns1997 commented May 2, 2024

@RubenRBS I created a cmake wrapper allowing us to build azure as modules. I would like your input before i go on to clean it up, add all modules of the sdk and add tests for each module.

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

github-actions bot commented May 2, 2024

Hooks produced the following warnings for commit 003f601
azure-sdk-for-cpp/1.11.3@#f75af9afb86d4f0f6ed326c3eca6a4e6
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './sdk/eventhubs/azure-messaging-eventhubs-checkpointstore-blob/inc/azure/messaging/eventhubs/checkpointstore_blob/blob_checkpoint_store.hpp' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

github-actions bot commented May 3, 2024

Hooks produced the following warnings for commit f0ee5f1
azure-sdk-for-cpp/1.11.3@#4107b8b1ed65c254217cac77cb3cf643
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './sdk/eventhubs/azure-messaging-eventhubs-checkpointstore-blob/inc/azure/messaging/eventhubs/checkpointstore_blob/blob_checkpoint_store.hpp' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@trns1997 trns1997 requested a review from memsharded May 4, 2024 11:53
@trns1997
Copy link
Contributor Author

trns1997 commented May 4, 2024

@RubenRBS @memsharded ready for review :)

@trns1997
Copy link
Contributor Author

@RubenRBS @memsharded, can you guys reviews when you have the time :)

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

Hooks produced the following warnings for commit 3c608ae
azure-sdk-for-cpp/1.11.3@#bc15b839e6aa5c12b85246bd14736de4
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './sdk/eventhubs/azure-messaging-eventhubs-checkpointstore-blob/inc/azure/messaging/eventhubs/checkpointstore_blob/blob_checkpoint_store.hpp' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 18 (3c608ae27a3ba2ec182c63a525b91cbb24ccac10):

  • azure-sdk-for-cpp/1.11.3:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 04c33a8 into conan-io:master Jul 11, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants