-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azure-sdk-for-cpp/1.11.3:new recipe #23663
azure-sdk-for-cpp/1.11.3:new recipe #23663
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thanks a lot for your contribution, we appreciate it
I took a quick look, will be able to have a better review next monday, but for now I've found a few minor things worth commenting on :)
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 34b5abaazure-sdk-for-cpp/1.11.3@#39f2d59183bbaf2eaebdde682b37406a
|
This comment has been minimized.
This comment has been minimized.
2c69930
to
79f8579
Compare
This comment has been minimized.
This comment has been minimized.
4a01f69
to
a7aabef
Compare
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit a7aabefazure-sdk-for-cpp/1.11.3@#d79345ae18633c2edb208e83b9fc4cc6
|
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit eec0523azure-sdk-for-cpp/1.11.3@#46cda78c8d544deb347afa02a23b0ed7
|
This comment has been minimized.
This comment has been minimized.
@RubenRBS I would like to get your inputs on this PR. I would like to install this package via Conan |
Hi @trns1997 , sorry for the delay, most of the team was attending a conference last week which delayed reviews a bit, will get back to you tomorrow :) |
…ter-index into new/azure-sdk-for-cpp
@RubenRBS I created a cmake wrapper allowing us to build azure as modules. I would like your input before i go on to clean it up, add all modules of the sdk and add tests for each module. |
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 003f601azure-sdk-for-cpp/1.11.3@#f75af9afb86d4f0f6ed326c3eca6a4e6
|
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit f0ee5f1azure-sdk-for-cpp/1.11.3@#4107b8b1ed65c254217cac77cb3cf643
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@RubenRBS @memsharded ready for review :) |
@RubenRBS @memsharded, can you guys reviews when you have the time :) |
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 3c608aeazure-sdk-for-cpp/1.11.3@#bc15b839e6aa5c12b85246bd14736de4
|
Conan v1 pipeline ✔️All green in build 18 (
|
Add azure-sdk-for-cpp https://github.com/Azure/azure-sdk-for-cpp as the old azure-storage-cpp (homepage = "https://github.com/Azure/azure-storage-cpp) is deprecated (conan deprecated package: #18842). Also couple of users requested to add this package to conan: Azure/azure-sdk-for-cpp#5485
For the moment I mainly focused on building the entire sdk and only on Linux. Windows and apple not supported yet, contributions welcomed!