Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

poselib: new recipe #24770

Merged
merged 4 commits into from
Aug 2, 2024
Merged

poselib: new recipe #24770

merged 4 commits into from
Aug 2, 2024

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Jul 30, 2024

Summary

Changes to recipe: poselib/2.0.3

Motivation

Minimal solvers for calibrated camera pose estimation.

https://github.com/PoseLib/PoseLib

Details

Related:

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@perseoGI perseoGI self-assigned this Aug 1, 2024
perseoGI
perseoGI requested changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@perseoGI perseoGI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

recipes/poselib/all/conandata.yml Outdated Show resolved Hide resolved
recipes/poselib/all/conanfile.py Show resolved Hide resolved
@valgur valgur mentioned this pull request Aug 1, 2024
Closed
uilianries
uilianries reviewed Aug 1, 2024
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

  • I would suggest improving the Windows message a little.
  • license, cpp_info, transitive eigen, required cppstd, all good!

Thank you!

recipes/poselib/all/conanfile.py Outdated Show resolved Hide resolved
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 4 (4eed30ff99c566cb3b4e13765d42eb0afa5b3067):

  • poselib/2.0.3:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 4 (4eed30ff99c566cb3b4e13765d42eb0afa5b3067):

  • poselib/2.0.3:
    All packages built successfully! (All logs)

uilianries
uilianries approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for asking a new release to the upstream! 👏

@uilianries uilianries requested a review from perseoGI August 2, 2024 06:24
@AbrilRBS AbrilRBS assigned AbrilRBS and unassigned perseoGI Aug 2, 2024
perseoGI
perseoGI approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@perseoGI perseoGI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

@conan-center-bot conan-center-bot merged commit b94c4b2 into conan-io:master Aug 2, 2024
12 checks passed
uilianries pushed a commit to uilianries/conan-center-index that referenced this pull request Aug 7, 2024
@valgur @uilianries
(conan-io#24770) poselib: new recipe
d4d0294 
* poselib: new recipe

* poselib: Windows shared builds are not supported

* poselib: improve error message

* poselib: use a version tag for the source archive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perseoGI perseoGI perseoGI approved these changes

@AbrilRBS AbrilRBS AbrilRBS approved these changes

@uilianries uilianries uilianries approved these changes

Assignees

@AbrilRBS AbrilRBS

@perseoGI perseoGI

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@valgur @conan-center-bot @uilianries @AbrilRBS @perseoGI