Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

capstone: add version 5.0.3 #25980

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Conversation

luadebug
Copy link
Contributor

@luadebug luadebug commented Nov 20, 2024

Summary

Changes to recipe: capstone/5.0.3

Motivation

acquire latest 5.0.

Details

capstone-engine/capstone@5.0.1...5.0.3


@luadebug luadebug changed the title Capstone update capstone: add version 5.0.3 Nov 20, 2024
@luadebug
Copy link
Contributor Author

luadebug commented Nov 20, 2024

I think during changes it would require just add clone of existing patch file over CMakeLists.txt. Just diff is
VERSION 5.0 => VERSION 5.0.3

project(capstone
    VERSION 5.0.3
)

@AbrilRBS AbrilRBS self-assigned this Nov 20, 2024
@luadebug
Copy link
Contributor Author

luadebug commented Nov 20, 2024

suite/check_wheel_bin_arch.py

filename = {
    "macosx": "libcapstone.dylib",
    "manylinux": "libcapstone.so",
    "musllinux": "libcapstone.so",
    "win": "capstone.dll",
}

Hm still Recipe hook warning for macOS in case of 5.0.3 version.

apple_relocatable_shared_libs
install_name dir of these shared libs is not @rpath: libcapstone.5.dylib, libcapstone.5.0.3.dylib, libcapstone.dylib

@luadebug
Copy link
Contributor Author

luadebug commented Nov 20, 2024

Lets see if fix_apple_shared_install_name going to fix rpath.

@luadebug
Copy link
Contributor Author

luadebug commented Nov 21, 2024

Lets see if
tc.cache_variables["CAPSTONE_BUILD_MACOS_THIN"] = True # Disable universal2 builds on macOS
is going to resolve issue.

apple_relocatable_shared_libs
install_name dir of these shared libs is not @rpath: libcapstone.5.dylib, libcapstone.5.0.3.dylib, libcapstone.dylib

I do still think for adding those lines into & placing
tc.cache_variables["CAPSTONE_BUILD_MACOS_THIN"] = False # Enable universal2 builds on macOS later on

    def package_id(self):
        if self._is_universal2(info=True):
            self.info.settings.arch = "universal:armv8/x86_64"

@luadebug
Copy link
Contributor Author

luadebug commented Nov 21, 2024

#25997
Nice changes, honestly unsure this is related to universal2 builds on macOS though.

@luadebug
Copy link
Contributor Author

luadebug commented Nov 22, 2024

macOS & Linux shared builds.

[
    {
        "identifier": "hook_fpic_management.py",
        "details": "'fPIC' option not managed correctly. Please remove it for shared option in the configure() method with self.options.rm_safe('fPIC') .",
        "hook_method": "pre_generate",
        "context": "capstone/5.0.3",
        "level": "warning"
    }
]

@luadebug
Copy link
Contributor Author

OK. This should finally resolve recipe linter & recipe hooks.

@luadebug
Copy link
Contributor Author

Thank you for your help @AbrilRBS.

@luadebug luadebug requested a review from AbrilRBS November 22, 2024 13:05
@luadebug luadebug requested a review from AbrilRBS November 22, 2024 13:31
@luadebug
Copy link
Contributor Author

luadebug commented Nov 23, 2024

I appreciate your help. Feel free to ping me.
I believe there is no need since https://docs.conan.io/2/reference/tools/cmake/cmaketoolchain.html#support-for-universal-binaries-in-macos should handle it.

@luadebug
Copy link
Contributor Author

luadebug commented Jan 7, 2025

@AbrilRBS any news?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants