dcmtk: maintenance changes #25997
Merged
dcmtk: maintenance changes #25997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcar87
force-pushed
the
lcc/maintenance/dcmtk-macos-crossbuild
branch
from
bbebe28 to
fa2c737
Compare
jcar87
commented
Nov 21, 2024
| @@ -0,0 +1,58 @@ | |||
| #ifndef CONFIG_ARITH_H | |||
There was a problem hiding this comment.
This file is generated doing a native build on macOS x86_64
Following the guidance at https://support.dcmtk.org/redmine/projects/dcmtk/wiki/Cross_Compiling#Generated-file-arithh
franramirez688
approved these changes
Nov 22, 2024
ErniGH
approved these changes
Nov 22, 2024
valgur
reviewed
Nov 27, 2024
| raise ConanInvalidConfiguration("MacOS crossbuilding is only supported to target x86_64") | ||
| else: | ||
| # Note: other cross-building scenarios have not been tested and may also need to be marked as invalid | ||
| self.output.warning("Crossbuilding has not been tested and may not work") |
There was a problem hiding this comment.
Cross-compilation is currently only possible if can_run() is true: valgur@0cb08c5
OMGtechy
pushed a commit
to OMGtechy/conan-center-index
that referenced
this pull request
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libpngandlibxml2validate_build()