Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added recipe for qwt 6.1.6 #4528

Closed
wants to merge 17 commits into from
Closed

Conversation

boussaffawalid
Copy link
Contributor

Specify library name and version: lib/1.0

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot

This comment has been minimized.

boussaffawalid and others added 2 commits February 11, 2021 14:21
Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>
Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@boussaffawalid
Copy link
Contributor Author

@ericLemanissier I got this error when building the test

error: #error "You must build your code with position independent code if Qt was built with -reduce-relocations. " "Compile your code with -fPIC (and not with -fPIE)."
 #  error "You must build your code with position independent code if Qt was built with -reduce-relocations. "\

How to check if qt package was created with -reduce-relocations or not ?

@conan-center-bot

This comment has been minimized.

@ericriff
Copy link
Contributor

ericriff commented Mar 19, 2021

@ericLemanissier I got this error when building the test

error: #error "You must build your code with position independent code if Qt was built with -reduce-relocations. " "Compile your code with -fPIC (and not with -fPIE)."
 #  error "You must build your code with position independent code if Qt was built with -reduce-relocations. "\

How to check if qt package was created with -reduce-relocations or not ?

I got this error while working on my QArchive recipe and I ended up setting fPIC on the test package's CMakeLists.txt with no checks.
https://github.com/conan-io/conan-center-index/blob/master/recipes/qarchive/all/test_package/CMakeLists.txt#L10

boussaffawalid and others added 2 commits March 20, 2021 14:43
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
prince-chrismc
prince-chrismc previously approved these changes Mar 20, 2021
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Comment on lines 7 to 9
add_executable(example example.cpp)
target_link_libraries(example CONAN_PKG::qt CONAN_PKG::qwt)
set_property(TARGET example PROPERTY CXX_STANDARD 11)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in other qt test packages, fPIC is usually enabled here

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@jgsogo
Copy link
Contributor

jgsogo commented May 24, 2021

What causes this ?

Might have been an old bug? the last log I see is from March

Let's wait and see if it happens again or not and we will dive into the sources. A lot of things have changed since March.

@ericLemanissier
Copy link
Contributor

the same thing happened: https://c3i.jfrog.io/c3i/misc/logs/pr/4528/15/qwt/6.1.6//02dd532ba76f7920165273b75f3536458790d051-build.txt ends with [HOOK - conan-center.py] post_package_info(): ERROR: [LIBRARY DOES NOT EXIST (KB-H054)] Component qwt::qwt library "libqwt_debug" not found in libdirs (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H054) but the error was ignored and the bot and started the test recipe.

@jgsogo
Copy link
Contributor

jgsogo commented May 25, 2021

@ericLemanissier , The bug is related to the hooks: conan-io/hooks#299, it was not raising for post_package_info hooks.

@ericLemanissier
Copy link
Contributor

@boussaffawalid do you have still some time to push this PR forward? If not I can apply some fixes on top of your branch

@boussaffawalid
Copy link
Contributor Author

@ericLemanissier please feel free to help here.

@ericLemanissier
Copy link
Contributor

@boussaffawalid I did a suggestion several days ago. My question is whether you still have some time to accept suggestions, if not, are you OK if I open another PR including your commits?

Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>
@boussaffawalid
Copy link
Contributor Author

@ericLemanissier sorry I did not notice your suggestion. I just accepted it! Lets see how the build goes.
It is also absolutely fine to open another PR including my commits.

@conan-center-bot

This comment has been minimized.

Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@ericLemanissier
Copy link
Contributor

LINK : fatal error LNK1181: cannot open input file 'C:\J\w\BuildSingleReference\.conan\data\freetype\2.10.4\_\_\package\f9af8f85027e8be7b7cc2377c3787464a13daca0\lib\freetype.lib': a comparable error happened in #5691 (comment) LINK : fatal error LNK1181: cannot open input file 'C:\J\w\BuildSingleReference\.conan\data\double-conversion\3.1.5\_\_\package\df81ad20137149d7a51276fd3e24009b45e5964a\lib\double-conversion.lib'
It was solved without modifying the recipe, just by restarting the build. Maybe it'll be as easy here ?

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Failure in build 22 (2808537072a74e8aeaf31571f0a19b265f2e0a90):

  • qwt/6.1.6@:
    CI failed to create some packages (All logs)

    Logs for packageID a589b82379105793b15cb207fff871dc8d0d0a79:
    [settings]
    arch=x86_64
    arch_build=x86_64
    build_type=Release
    compiler=Visual Studio
    compiler.runtime=MT
    compiler.version=16
    os=Windows
    os_build=Windows
    [options]
    qwt:shared=True
    
    [...]
    moc_qwt_panner.cpp
    moc_qwt_picker.cpp
    moc_qwt_text_label.cpp
    moc_qwt_abstract_legend.cpp
    moc_qwt_legend.cpp
    moc_qwt_legend_label.cpp
    moc_qwt_plot.cpp
    moc_qwt_plot_renderer.cpp
    moc_qwt_plot_canvas.cpp
    moc_qwt_plot_panner.cpp
    moc_qwt_plot_picker.cpp
    moc_qwt_plot_zoomer.cpp
    moc_qwt_plot_magnifier.cpp
    moc_qwt_sampling_thread.cpp
    moc_qwt_scale_widget.cpp
    moc_qwt_plot_glcanvas.cpp
    moc_qwt_abstract_slider.cpp
    moc_qwt_abstract_scale.cpp
    Generating Code...
    Compiling...
    moc_qwt_analog_clock.cpp
    moc_qwt_compass.cpp
    moc_qwt_counter.cpp
    moc_qwt_dial.cpp
    moc_qwt_knob.cpp
    moc_qwt_slider.cpp
    moc_qwt_thermo.cpp
    moc_qwt_wheel.cpp
    Generating Code...
    linking ..\lib\qwt.dll 
    LINK : fatal error LNK1181: cannot open input file 'C:\J\w\BuildSingleReference@4\.conan\data\freetype\2.10.4\_\_\package\f7cfa0039d91d91f3635d7741b30770c314ce224\lib\freetype.lib'
    qwt/6.1.6: 
    qwt/6.1.6: WARN: Build folder is dirty, removing it: C:\J\w\BuildSingleReference@3\.conan\data\qwt\6.1.6\_\_\build\a589b82379105793b15cb207fff871dc8d0d0a79
    
    Microsoft (R) Program Maintenance Utility Version 14.28.29333.0
    Copyright (C) Microsoft Corporation.  All rights reserved.
    
    
    Microsoft (R) Program Maintenance Utility Version 14.28.29333.0
    Copyright (C) Microsoft Corporation.  All rights reserved.
    
    NMAKE : fatal error U1077: 'echo' : return code '0x49d'
    Stop.
    NMAKE : fatal error U1077: 'cd' : return code '0x2'
    Stop.
    qwt/6.1.6: ERROR: Package 'a589b82379105793b15cb207fff871dc8d0d0a79' build failed
    qwt/6.1.6: WARN: Build folder C:\J\w\BuildSingleReference@3\.conan\data\qwt\6.1.6\_\_\build\a589b82379105793b15cb207fff871dc8d0d0a79
    ERROR: qwt/6.1.6: Error in build() method, line 91
    	self.run("{} && nmake".format(vcvars))
    	ConanException: Error 2 while executing set "VSCMD_START_DIR=%CD%" && call "C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC/Auxiliary/Build/vcvarsall.bat" amd64 && nmake
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@ericLemanissier
Copy link
Contributor

ericLemanissier commented Jun 2, 2021

I'm not sure why the bot continues to rebuild the same commit. The error seems to happen because qt encodes absolute path to its dependencies in files (.prl for example) during build, and these dependencies are not always at the same place when qt is consumed. This looks like QTBUG-72903 but it should already be fixed :/ I don't have much time for this currently, so if someone wants to investigate, (s)he should not hesitate !

EDIT: this is actually https://bugreports.qt.io/browse/QTBUG-87054

@jgsogo
Copy link
Contributor

jgsogo commented Jun 2, 2021

I've triggered this PR again after building qt/5.15.2 package that was missing. So then, it looks like the error is no longer on CI side, but on library/PR...

@ericLemanissier
Copy link
Contributor

blocked by #5730

@ericLemanissier
Copy link
Contributor

@boussaffawalid you can try to close and reopen this pr, to retrigger a build. It should pass now that #5730 is merged

@ericLemanissier ericLemanissier mentioned this pull request Jun 14, 2021
4 tasks
@ghost
Copy link

ghost commented Jun 14, 2021

I detected other pull requests that are modifying qwt/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants