-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added recipe for qwt 6.1.6 #4528
Conversation
This comment has been minimized.
This comment has been minimized.
Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>
Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@ericLemanissier I got this error when building the test
How to check if qt package was created with -reduce-relocations or not ? |
This comment has been minimized.
This comment has been minimized.
I got this error while working on my |
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
add_executable(example example.cpp) | ||
target_link_libraries(example CONAN_PKG::qt CONAN_PKG::qwt) | ||
set_property(TARGET example PROPERTY CXX_STANDARD 11) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in other qt test packages, fPIC is usually enabled here
This comment has been minimized.
This comment has been minimized.
This reverts commit 7aa4fc3.
This comment has been minimized.
This comment has been minimized.
Let's wait and see if it happens again or not and we will dive into the sources. A lot of things have changed since March. |
the same thing happened: https://c3i.jfrog.io/c3i/misc/logs/pr/4528/15/qwt/6.1.6//02dd532ba76f7920165273b75f3536458790d051-build.txt ends with |
@ericLemanissier , The bug is related to the hooks: conan-io/hooks#299, it was not raising for |
@boussaffawalid do you have still some time to push this PR forward? If not I can apply some fixes on top of your branch |
@ericLemanissier please feel free to help here. |
@boussaffawalid I did a suggestion several days ago. My question is whether you still have some time to accept suggestions, if not, are you OK if I open another PR including your commits? |
Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>
@ericLemanissier sorry I did not notice your suggestion. I just accepted it! Lets see how the build goes. |
This comment has been minimized.
This comment has been minimized.
Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Failure in build 22 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
I'm not sure why the bot continues to rebuild the same commit. The error seems to happen because qt encodes absolute path to its dependencies in files (.prl for example) during build, and these dependencies are not always at the same place when qt is consumed. This looks like QTBUG-72903 but it should already be fixed :/ I don't have much time for this currently, so if someone wants to investigate, (s)he should not hesitate ! EDIT: this is actually https://bugreports.qt.io/browse/QTBUG-87054 |
I've triggered this PR again after building |
blocked by #5730 |
@boussaffawalid you can try to close and reopen this pr, to retrigger a build. It should pass now that #5730 is merged |
I detected other pull requests that are modifying qwt/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
Specify library name and version: lib/1.0
conan-center hook activated.