qwt 6.1.6 #5887

ericLemanissier · 2021-06-14T12:02:33Z

Specify library name and version: qwt/6.1.6

all the work has be done by @boussaffawalid , kudos to him !

closes #4528

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.

Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>

Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>

This reverts commit 7aa4fc3.

Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>

ghost · 2021-06-14T12:18:00Z

I detected other pull requests that are modifying qwt/all recipe:

added recipe for qwt 6.1.6 #4528

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

SpaceIm · 2021-06-14T13:12:09Z

recipes/qwt/all/conanfile.py

+            self.run("{} && qmake {}".format(vcvars, self._source_subfolder), run_environment=True)
+            self.run("{} && nmake".format(vcvars))
+        else:
+            self.run("qmake {}".format(self._source_subfolder), run_environment=True)
+            self.run("make -j {}".format(tools.cpu_count()))


Is it robust?

What about MinGW?
Cross compilation? (qt is not in build requirements, I guess qmake comes from qt recipe).

yes you are right: qmake comes from qt recipe.
Can a recipe be both a requirement and a build_requirement at the same time ?

yes, it works like a charm with 2 profiles. It also works with 1 profile, but it breaks quickly when versions are different in requirements and build requirements.

AFAIR, conan plans to change 1 profile so that it behaves like 2 profiles.

Until it's implemented, you can do:

def requirements(self): self.requires("qt/5.15.2") def build_requirements(self): if tools.cross_building(self.settings): self.build_requires("qt/5.15.2")

qmake is always intended to run on the build platform, so it should be fine without this change right ?

Conan v2 will always work as if there were two profiles defined. Here in CCI we are now adding our first cross-building scenario (we are fighting with M1) and the plan is to start using two profiles for all the builds (for native ones) at some point in time. We need to check that they work as expected, specially regarding the computation of package IDs.

I don't think it's required to have things like MinGW and cross-compilation in the first iteration.
having recipe what works only for native builds is still better than having no recipes, and it would probably satisfy ~90% of users.
things like MinGW and cross-building could be added on demand.

recipes/qwt/all/conanfile.py

prince-chrismc · 2021-06-15T13:34:08Z

recipes/qwt/all/conandata.yml

@@ -0,0 +1,4 @@
+sources:
+  "6.1.6":
+    url: "https://sourceforge.net/projects/qwt/files/qwt/6.1.6/qwt-6.1.6.zip"


recipes/qwt/all/test_package/CMakeLists.txt

prince-chrismc · 2021-06-15T13:38:35Z

recipes/qwt/all/conanfile.py

+        "thermometers, wheels and knobs to control or display values, arrays, or ranges of type double."
+    )
+    settings = "os", "compiler", "build_type", "arch"
+    options = {


Do we want to follow https://github.com/conan-io/conan-center-index/blob/master/docs/reviewing.md#recommended-feature-options-names?

Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>

prince-chrismc · 2021-06-15T21:54:22Z

expanded command line ... too long

RIP I've never seen that 🤯

boussaffawalid · 2021-06-15T22:00:36Z

probbaly it is better to use Ninja instead of nmake, also it may make sense to enable ninja response file. (CMAKE_NINJA_FORCE_RESPONSE_FILE)

conan-center-bot · 2021-06-16T06:17:38Z

All green in build 3 (ff0457c95d8fea23a4d48c5638d7d3c3795592dd):

qwt/6.1.6@:
All packages built successfully! (All logs)

* added recipe for qwt 6.1.6 * Update recipes/qwt/all/conanfile.py Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com> * Update recipes/qwt/all/conanfile.py Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com> * fixed conan test * Update recipes/qwt/all/conanfile.py Co-authored-by: Chris Mc <prince.chrismc@gmail.com> * Update recipes/qwt/all/conanfile.py Co-authored-by: Chris Mc <prince.chrismc@gmail.com> * del self.options.fPIC for test package * del self.options.fPIC for test package * use get_safe to check fPIC option * set target_compile_options to -fPIC * fix debug lib name for non windows system * Update recipes/qwt/all/conanfile.py Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com> * Update recipes/qwt/all/test_package/CMakeLists.txt Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com> * Revert "Update recipes/qwt/all/test_package/CMakeLists.txt" This reverts commit 7aa4fc3. * Update recipes/qwt/all/conanfile.py Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com> * Update recipes/qwt/all/conanfile.py Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com> * specify required_conan_version * Apply suggestions from code review Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com> * use jom instead of nmake Co-authored-by: Walid Boussaffa <boussaffa.walid@outlook.com> Co-authored-by: Chris Mc <prince.chrismc@gmail.com> Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>

boussaffawalid and others added 18 commits February 10, 2021 12:49

added recipe for qwt 6.1.6

7f72560

Update recipes/qwt/all/conanfile.py

e89990d

Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>

Update recipes/qwt/all/conanfile.py

9cf0e1b

Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>

fixed conan test

e7d9db7

Update recipes/qwt/all/conanfile.py

0354156

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>

Update recipes/qwt/all/conanfile.py

fe562e5

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>

del self.options.fPIC for test package

fb23049

del self.options.fPIC for test package

44abab3

use get_safe to check fPIC option

fc700ae

Merge remote-tracking branch 'upstream/master' into qwt

07171bd

set target_compile_options to -fPIC

b3c4f56

fix debug lib name for non windows system

716a6e4

Update recipes/qwt/all/conanfile.py

3f4a501

Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>

Update recipes/qwt/all/test_package/CMakeLists.txt

7aa4fc3

Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>

Revert "Update recipes/qwt/all/test_package/CMakeLists.txt"

af7f204

This reverts commit 7aa4fc3.

Update recipes/qwt/all/conanfile.py

b6cc391

Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>

Update recipes/qwt/all/conanfile.py

2808537

Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>

specify required_conan_version

2ae9cc1

ghost mentioned this pull request Jun 14, 2021

[service] Potentially conflicting recipes #3571

Closed

ghost mentioned this pull request Jun 14, 2021

added recipe for qwt 6.1.6 #4528

Closed

4 tasks

github-actions bot mentioned this pull request Jun 14, 2021

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

This comment has been minimized.

Sign in to view

SpaceIm reviewed Jun 14, 2021

View reviewed changes

recipes/qwt/all/conanfile.py Outdated Show resolved Hide resolved

SpaceIm reviewed Jun 14, 2021

View reviewed changes

recipes/qwt/all/conanfile.py Outdated Show resolved Hide resolved

jgsogo previously approved these changes Jun 14, 2021

View reviewed changes

SSE4 requested a review from uilianries June 15, 2021 08:41

SSE4 previously approved these changes Jun 15, 2021

View reviewed changes

prince-chrismc reviewed Jun 15, 2021

View reviewed changes

Apply suggestions from code review

126f9c6

Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>

ericLemanissier dismissed stale reviews from SSE4 and jgsogo via 126f9c6 June 15, 2021 19:13

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Jun 15, 2021

prince-chrismc previously approved these changes Jun 15, 2021

View reviewed changes

ericLemanissier dismissed prince-chrismc’s stale review via ff0457c June 16, 2021 05:23

use jom instead of nmake

ff0457c

conan-center-bot removed the Failed label Jun 16, 2021

SSE4 approved these changes Jun 16, 2021

View reviewed changes

prince-chrismc approved these changes Jun 17, 2021

View reviewed changes

jgsogo approved these changes Jun 17, 2021

View reviewed changes

conan-center-bot merged commit a2feaf7 into conan-io:master Jun 17, 2021

ericLemanissier deleted the patch-2 branch June 17, 2021 08:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

qwt 6.1.6 #5887

qwt 6.1.6 #5887

ericLemanissier commented Jun 14, 2021

ghost commented Jun 14, 2021

This comment has been minimized.

SpaceIm Jun 14, 2021

boussaffawalid Jun 14, 2021

SpaceIm Jun 14, 2021 •

edited

Loading

ericLemanissier Jun 14, 2021 •

edited

Loading

jgsogo Jun 14, 2021

SSE4 Jun 15, 2021

prince-chrismc Jun 15, 2021

prince-chrismc Jun 15, 2021

This comment has been minimized.

prince-chrismc commented Jun 15, 2021

boussaffawalid commented Jun 15, 2021

conan-center-bot commented Jun 16, 2021

qwt 6.1.6 #5887

qwt 6.1.6 #5887

Conversation

ericLemanissier commented Jun 14, 2021

ghost commented Jun 14, 2021

This comment has been minimized.

SpaceIm Jun 14, 2021

Choose a reason for hiding this comment

boussaffawalid Jun 14, 2021

Choose a reason for hiding this comment

SpaceIm Jun 14, 2021 • edited Loading

Choose a reason for hiding this comment

ericLemanissier Jun 14, 2021 • edited Loading

Choose a reason for hiding this comment

jgsogo Jun 14, 2021

Choose a reason for hiding this comment

SSE4 Jun 15, 2021

Choose a reason for hiding this comment

prince-chrismc Jun 15, 2021

Choose a reason for hiding this comment

prince-chrismc Jun 15, 2021

Choose a reason for hiding this comment

This comment has been minimized.

prince-chrismc commented Jun 15, 2021

boussaffawalid commented Jun 15, 2021

conan-center-bot commented Jun 16, 2021

SpaceIm Jun 14, 2021 •

edited

Loading

ericLemanissier Jun 14, 2021 •

edited

Loading