Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bzip2: replace os.rename with tools.rename #5412

Merged
merged 3 commits into from
May 4, 2021
Merged

bzip2: replace os.rename with tools.rename #5412

merged 3 commits into from
May 4, 2021

Conversation

klimkin
Copy link
Contributor

@klimkin klimkin commented May 3, 2021

Fixes #5359 for bzip2.

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@klimkin @ericLemanissier
Update recipes/bzip2/all/conanfile.py
d318eec 
Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>
@klimkin @ericLemanissier
Update recipes/bzip2/all/conanfile.py
f77433d 
Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>
@github-actions github-actions bot mentioned this pull request May 3, 2021
Open
@conan-center-bot
Copy link
Collaborator

All green in build 3 (f77433d22d11d9526f32cef67e2c7fe51407b8eb):

  • bzip2/1.0.8@:
    All packages built successfully! (All logs)

  • bzip2/1.0.6@:
    All packages built successfully! (All logs)

@SSE4 SSE4 requested a review from uilianries May 4, 2021 11:26
@conan-center-bot conan-center-bot merged commit 5e76d62 into conan-io:master May 4, 2021
AlvaroFS pushed a commit to AlvaroFS/conan-center-index that referenced this pull request May 7, 2021
@klimkin @ericLemanissier @AlvaroFS
(conan-io#5412) bzip2: replace os.rename with tools.rename
0870534 
* bzip2: replace os.rename with tools.rename

Fixes conan-io#5359 for bzip2.

* Update recipes/bzip2/all/conanfile.py

Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>

* Update recipes/bzip2/all/conanfile.py

Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>

Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>
@klimkin klimkin deleted the hotfix/bzip2-os-rename branch June 21, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericLemanissier ericLemanissier ericLemanissier approved these changes

@Croydon Croydon Croydon approved these changes

@SSE4 SSE4 SSE4 approved these changes

@uilianries uilianries Awaiting requested review from uilianries

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[package] all: "Access is denied" in os.rename() on Windows
5 participants
@klimkin @conan-center-bot @SSE4 @Croydon @ericLemanissier