Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[package] all: "Access is denied" in os.rename() on Windows #5359

Closed
klimkin opened this issue Apr 28, 2021 · 1 comment · Fixed by #5410, #5411, #5412, #5415 or #5416
Closed

[package] all: "Access is denied" in os.rename() on Windows #5359

klimkin opened this issue Apr 28, 2021 · 1 comment · Fixed by #5410, #5411, #5412, #5415 or #5416
Labels
bug Something isn't working

Comments

@klimkin
Copy link
Contributor

klimkin commented Apr 28, 2021

Package and Environment Details (include every applicable attribute)

  • Package Name/Version: almost all packages affected
  • Operating System+version: Windows 10
  • Compiler+version: MSVC 16
  • Conan version: conan 1.35.2
  • Python version: Python 3.8.7

Conan profile (output of conan profile show default or conan profile show <profile> if custom profile is in use)

[settings]
os_build=Windows
os=Windows
arch=x86_64
arch_build=x86_64
compiler=Visual Studio
compiler.version=16
compiler.runtime=MD
build_type=Release

Steps to reproduce (Include if Applicable)

This is a known issue. Solution provided by conan-io/conan#6774
However most recipes still use os.rename() and not tools.rename().

Log

b2/4.2.0: Configuring sources in C:\Users\xxx\.conan\data\b2\4.2.0\_\_\source
ERROR: b2/4.2.0: Error in source() method, line 58
os.rename(extracted_dir, "source")
PermissionError: [WinError 5] Access is denied: 'build-4.2.0' -> 'source'
@klimkin klimkin added the bug Something isn't working label Apr 28, 2021
@uilianries
Copy link
Member

@klimkin Thank you for reporting, we can add it to Hooks and prevent future errors.

@uilianries uilianries mentioned this issue Apr 28, 2021
Open
adklimki pushed a commit to klimkin/conan-center-index that referenced this issue May 3, 2021
@klimkin
boost: replace os.rename with tools.rename
c41d0a8 
Fixes conan-io#5359 for boost.
adklimki pushed a commit to klimkin/conan-center-index that referenced this issue May 3, 2021
@klimkin
libiconv: replace os.rename with tools.rename
66e023e 
Fixes conan-io#5359 for libiconv.
@klimkin klimkin mentioned this issue May 3, 2021
Merged
4 tasks
adklimki pushed a commit to klimkin/conan-center-index that referenced this issue May 3, 2021
@klimkin
zlib: replace os.rename with tools.rename
80183cd 
Fixes conan-io#5359 for zlib.
adklimki pushed a commit to klimkin/conan-center-index that referenced this issue May 3, 2021
@klimkin
zlib: replace os.rename with tools.rename
7001cf8 
Fixes conan-io#5359 for zlib.
@klimkin klimkin mentioned this issue May 3, 2021
Merged
4 tasks
adklimki pushed a commit to klimkin/conan-center-index that referenced this issue May 3, 2021
@klimkin
bzip2: replace os.rename with tools.rename
1120de5 
Fixes conan-io#5359 for bzip2.
@klimkin klimkin mentioned this issue May 3, 2021
Merged
4 tasks
adklimki pushed a commit to klimkin/conan-center-index that referenced this issue May 3, 2021
@klimkin
gtest: replace os.rename with tools.rename
5fbdb4d 
Fixes conan-io#5359 for gtest.
@klimkin klimkin mentioned this issue May 3, 2021
Closed
4 tasks
adklimki pushed a commit to klimkin/conan-center-index that referenced this issue May 3, 2021
@klimkin
zlib: replace os.rename with tools.rename
629f51c 
Fixes conan-io#5359 for zlib/1.2.11.
adklimki pushed a commit to klimkin/conan-center-index that referenced this issue May 3, 2021
@klimkin
libxml2: replace os.rename with tools.rename
eeb4b87 
Fixes conan-io#5359 for libxml2.
@klimkin klimkin mentioned this issue May 3, 2021
Closed
4 tasks
adklimki pushed a commit to klimkin/conan-center-index that referenced this issue May 3, 2021
@klimkin
sqlite3: replace os.rename with tools.rename
1ea0116 
Fixes conan-io#5359 for sqlite3.
@klimkin klimkin mentioned this issue May 3, 2021
Merged
4 tasks
adklimki pushed a commit to klimkin/conan-center-index that referenced this issue May 3, 2021
@klimkin
zulu-openjdk: replace os.rename with tools.rename
2495a25 
Fixes conan-io#5359 for zulu-openjdk.
@klimkin klimkin mentioned this issue May 3, 2021
Merged
4 tasks
adklimki pushed a commit to klimkin/conan-center-index that referenced this issue May 3, 2021
@klimkin
boost: replace os.rename with tools.rename
13b056f 
Fixes conan-io#5359 for boost.
conan-center-bot pushed a commit that referenced this issue May 4, 2021
@klimkin @ericLemanissier
(#5410) libiconv: replace os.rename with tools.rename
8c6663b 
* libiconv: replace os.rename with tools.rename

Fixes #5359 for libiconv.

* Update recipes/libiconv/all/conanfile.py

Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>

* Remove reduntant tools.rename

Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>
conan-center-bot pushed a commit that referenced this issue May 4, 2021
@klimkin @ericLemanissier
(#5412) bzip2: replace os.rename with tools.rename
5e76d62 
* bzip2: replace os.rename with tools.rename

Fixes #5359 for bzip2.

* Update recipes/bzip2/all/conanfile.py

Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>

* Update recipes/bzip2/all/conanfile.py

Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>

Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>
conan-center-bot pushed a commit that referenced this issue May 4, 2021
@klimkin
(#5415) sqlite3: replace os.rename with tools.rename
e16b656 
Fixes #5359 for sqlite3.
conan-center-bot pushed a commit that referenced this issue May 4, 2021
@klimkin
(#5416) zulu-openjdk: replace os.rename with tools.rename
6121eb4 
Fixes #5359 for zulu-openjdk.
conan-center-bot pushed a commit that referenced this issue May 6, 2021
@klimkin
(#5411) zlib: replace os.rename with tools.rename
00df7f8 
* zlib: replace os.rename with tools.rename

Fixes #5359 for zlib/1.2.11.

* Simplify using tools.get with strip_root=True

* Fix error when renaming into the same filename
AlvaroFS pushed a commit to AlvaroFS/conan-center-index that referenced this issue May 7, 2021
@klimkin @ericLemanissier @AlvaroFS
(conan-io#5410) libiconv: replace os.rename with tools.rename
902ec30 
* libiconv: replace os.rename with tools.rename

Fixes conan-io#5359 for libiconv.

* Update recipes/libiconv/all/conanfile.py

Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>

* Remove reduntant tools.rename

Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>
AlvaroFS pushed a commit to AlvaroFS/conan-center-index that referenced this issue May 7, 2021
@klimkin @ericLemanissier @AlvaroFS
(conan-io#5412) bzip2: replace os.rename with tools.rename
0870534 
* bzip2: replace os.rename with tools.rename

Fixes conan-io#5359 for bzip2.

* Update recipes/bzip2/all/conanfile.py

Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>

* Update recipes/bzip2/all/conanfile.py

Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>

Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>
AlvaroFS pushed a commit to AlvaroFS/conan-center-index that referenced this issue May 7, 2021
@klimkin @AlvaroFS
(conan-io#5415) sqlite3: replace os.rename with tools.rename
1f89642 
Fixes conan-io#5359 for sqlite3.
AlvaroFS pushed a commit to AlvaroFS/conan-center-index that referenced this issue May 7, 2021
@klimkin @AlvaroFS
(conan-io#5416) zulu-openjdk: replace os.rename with tools.rename
b2ee2c7 
Fixes conan-io#5359 for zulu-openjdk.
AlvaroFS pushed a commit to AlvaroFS/conan-center-index that referenced this issue May 7, 2021
@klimkin @AlvaroFS
(conan-io#5411) zlib: replace os.rename with tools.rename
c664a96 
* zlib: replace os.rename with tools.rename

Fixes conan-io#5359 for zlib/1.2.11.

* Simplify using tools.get with strip_root=True

* Fix error when renaming into the same filename
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@klimkin @uilianries