Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libxml2: replace os.rename with tools.rename #5414

Closed
wants to merge 1 commit into from

Conversation

klimkin
Copy link
Contributor

@klimkin klimkin commented May 3, 2021

Fixes #5359 for libxml2.


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot

This comment has been minimized.

@klimkin klimkin closed this May 3, 2021
@klimkin klimkin reopened this May 3, 2021
@conan-center-bot
Copy link
Collaborator

Failure in build 2 (eeb4b877c077cc64fb141c4246a9122acfd36003):

  • libxml2/2.9.10@:
    CI failed to create some packages (All logs)

    Logs for packageID 492a889d8e023891e43e6f14ed7b01993a9e3f1c:
    [settings]
    arch=x86_64
    arch_build=x86_64
    build_type=Debug
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=7
    os=Linux
    os_build=Linux
    [options]
    libxml2:shared=False
    
    [...]
    build_type=Debug
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=7
    os=Linux
    os_build=Linux
    [options]
    libxml2:shared=False
    [build_requires]
    [env]
    
    libxml2/2.9.10: Forced build from source
    Installing package: libxml2/2.9.10
    Requirements
        libiconv/1.16 from 'conan-center' - Cache
        libxml2/2.9.10 from local cache - Cache
        zlib/1.2.11 from 'conan-center' - Cache
    Packages
        libiconv/1.16:db2ca884c9793e0b0fb54ec3f846326d1addacc8 - Cache
        libxml2/2.9.10:492a889d8e023891e43e6f14ed7b01993a9e3f1c - Build
        zlib/1.2.11:db2ca884c9793e0b0fb54ec3f846326d1addacc8 - Cache
    Build requirements
        pkgconf/1.7.3 from 'conan-center' - Cache
    Build requirements packages
        pkgconf/1.7.3:db2ca884c9793e0b0fb54ec3f846326d1addacc8 - Cache
    
    Installing (downloading, building) binaries...
    libiconv/1.16: Already installed!
    libiconv/1.16: Appending PATH environment var: /home/conan/w/BuildSingleReference/.conan/data/libiconv/1.16/_/_/package/db2ca884c9793e0b0fb54ec3f846326d1addacc8/bin
    [HOOK - conan-center.py] post_package_info(): [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] OK
    [HOOK - conan-center.py] post_package_info(): [LIBRARY DOES NOT EXIST (KB-H054)] OK
    pkgconf/1.7.3: Already installed!
    pkgconf/1.7.3: Appending PATH env var: /home/conan/w/BuildSingleReference/.conan/data/pkgconf/1.7.3/_/_/package/db2ca884c9793e0b0fb54ec3f846326d1addacc8/bin
    pkgconf/1.7.3: Setting PKG_CONFIG env var: /home/conan/w/BuildSingleReference/.conan/data/pkgconf/1.7.3/_/_/package/db2ca884c9793e0b0fb54ec3f846326d1addacc8/bin/pkgconf
    pkgconf/1.7.3: Appending AUTOMAKE_CONAN_INCLUDES env var: /home/conan/w/BuildSingleReference/.conan/data/pkgconf/1.7.3/_/_/package/db2ca884c9793e0b0fb54ec3f846326d1addacc8/bin/aclocal
    [HOOK - conan-center.py] post_package_info(): [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] OK
    [HOOK - conan-center.py] post_package_info(): [LIBRARY DOES NOT EXIST (KB-H054)] OK
    zlib/1.2.11: Already installed!
    [HOOK - conan-center.py] post_package_info(): [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] OK
    [HOOK - conan-center.py] post_package_info(): [LIBRARY DOES NOT EXIST (KB-H054)] OK
    libxml2/2.9.10: Applying build-requirement: pkgconf/1.7.3
    [HOOK - conan-center.py] pre_source(): [IMMUTABLE SOURCES (KB-H010)] OK
    libxml2/2.9.10: Configuring sources in /home/conan/w/BuildSingleReference/.conan/data/libxml2/2.9.10/_/_/source
    
    libxml2/2.9.10: WARN: Build folder is dirty, removing it: /home/conan/w/BuildSingleReference/.conan/data/libxml2/2.9.10/_/_/build/492a889d8e023891e43e6f14ed7b01993a9e3f1c
    libxml2/2.9.10: WARN: Trying to remove corrupted source folder
    libxml2/2.9.10: WARN: This can take a while for big packages
    ERROR: libxml2/2.9.10: Error in source() method, line 102
    	tools.get(**self.conan_data["sources"][self.version], destination=self._source_subfolder, strip_root=True)
    	KeyError: "linkname 'libxml2-2.9.10/test/relaxng/ambig_name-class.xml' not found"
    
  • libxml2/2.9.9@:
    All packages built successfully! (All logs)


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@@ -99,8 +99,7 @@ def build_requirements(self):
self.build_requires("msys2/20200517")

def source(self):
tools.get(**self.conan_data["sources"][self.version])
os.rename("libxml2-{0}".format(self.version), self._source_subfolder)
tools.get(**self.conan_data["sources"][self.version], destination=self._source_subfolder, strip_root=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the archive is the wrong format

@stale
Copy link

stale bot commented Jun 3, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 3, 2021
@stale
Copy link

stale bot commented Jul 3, 2021

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.

@stale stale bot closed this Jul 3, 2021
@klimkin klimkin deleted the hotfix/libxml2-os-rename branch June 21, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[package] all: "Access is denied" in os.rename() on Windows
5 participants