-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boost.python requires numpy. Fix function _run_python_script(). #5643
Conversation
I detected other pull requests that are modifying boost/all recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
Is numpy dependency new for Boost.Python? I'm currently using 1.74.0 that was built without conan and without numpy. |
From this vcpkg issue it seems that Boost should check during build if numpy is installed or not and decides whether to build boost numpy library based on that result. If it builds boost numpy this will result in an extra library (libboost_numpy39.lib on Windows). In general: if the check for python package numpy in this PR is a problem, then better to remove that part and think about how we can fix it properly later. The other patch is more important, because it completely messes up the boost python build on Windows and it takes quite a bit of time and debugging to find out what is going wrong. |
ps: I don't understand why the license/cla is shown as 'not signed yet'. I have already signed it multiple times and have submitted PRs before. I signed the CLA again yesterday, but no result yet. |
The commits is @winfriedd ... you need to sign the CLA with that account |
Thanks, I didn't even know I had that other Github account. I will close that asap. |
…roken when script returns empty output.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…heck, needs more investigation
the following code could be used to detect numpy (better in another PR):
|
Thanks. I noticed that when building the test_package with VS2019 linking the numpy.cpp executable fails with unresolved synbol errors to boost numpy. So I removed numpy stuff from this PR, needs more investigation. |
All green in build 6 (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…_script(). * Boost.python requires numpy. Fix function _run_python_script(), was broken when script returns empty output. * Boost: implement PR conan-io#5643 feedback from @SSE4. Remove numpy check, needs more investigation
Specify library name and version: boost/all_versions
First fix:
Function
_run_python_script
was broken when provided script returns empty output.And on Windows the script that
_python_abiflags(self)
sends to_run_python_script
does return no output. As a result the_run_python_script
returned something likeinstead of an empty string. Result was the following error message when building the boost recipe with option
without_python=False
even though python libraries were present:ERROR: boost/1.76.0: Invalid configuration: couldn't locate python libraries - make sure you have installed python development files
Second fix:
Build of Boost.python library will fail if python package numpy is not installed. Check for presence of numpy in validate().
conan-center hook activated.