[boost] For Visual Studio, pass some values of settings.compiler.toolset to B2 #5119

datalogics-kam · 2021-04-02T15:33:54Z

Specify library name and version: conan/1.75.0

This fixes a problem we had where compiler.version=16 and compiler.toolset=v141, but B2 was still using the v142 compiler.

If compiler.toolset is set, use that rather than inferring the toolset from the compiler.version.
If the toolset is specified, don't also use tools.vcvars(). Doing so seems to cause B2 to build Boost with the wrong toolset, even though it says it chose the desired compiler.

I implemented this for compiler.toolset that is in the form vNNN. I'm unsure of how the other values from `settings.yml' work. I would expect that people that use those toolsets could extend this work.

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.

ghost · 2021-04-02T15:39:14Z

I detected other pull requests that are modifying boost/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

datalogics-kam · 2021-04-02T18:17:28Z

The failure was:

MSBUILD : error MSB4166: Child node "5" exited prematurely. Shutting down.

It's a problem we run into a lot when there are multiple parallel builds running on the same machine.

The failure can probably be avoided globally for all jobs by setting the environment variable MSBUILDDISABLENODEREUSE=1, see here.

datalogics-kam · 2021-04-13T17:04:41Z

I rebased this to get it onto the latest master branch and to run the tests again. It's still getting this.

MSBUILD : error MSB4166: Child node "2" exited prematurely.

As mentioned above, that's not related to the code but to a well-known problem with MSBuild.

How can we resolve this? We've had the same problem at our company, and we solved it by telling MSBuild to not reuse nodes.

stale · 2021-06-25T22:18:12Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

prince-chrismc · 2021-08-22T23:55:37Z

recipes/boost/all/conanfile.py

@@ -1189,9 +1193,20 @@ def create_library_config(deps_name, name):
        filename = "%s/user-config.jam" % folder
        tools.save(filename,  contents)

+    @property
+    def _msvc_toolset(self):


🤔 would this be the same? https://docs.conan.io/en/latest/reference/tools.html#tools-msvs-toolset

prince-chrismc · 2021-08-22T23:57:56Z

👋 @uilianries @SSE4 @madebr @SpaceIm This is an old PR that seems to fix how settings are passed.

It looks correct to me but I am not sure what the implications might be, if you have a chance please review 👀

datalogics-kam · 2021-08-24T17:08:35Z

I'm confused about some of the failures, because

conan create recipes/boost/all boost/1.70.0@kam/testing -s arch=armv8 --build missing

...is working for me, with a configuration of:

Configuration:
[settings]
arch=armv8
arch_build=x86_64
build_type=Release
compiler=apple-clang
compiler.libcxx=libc++
compiler.version=12.0
os=Macos
os_build=Macos
[options]
[build_requires]
[env]

Xcode 12.4 and CMake 3.19.1.

Recommendations?

prince-chrismc · 2021-08-25T01:19:30Z

👋 @jgsogo @SpaceIm Boost is failing on the new Mac M1 profile... I've never worked on it so hopefully you guys can take a peak and help us 🙏

prince-chrismc · 2021-08-25T01:21:11Z

Ohh I found this in another PR #6929 (comment)

datalogics-kam · 2021-10-09T00:51:20Z

@prince-chrismc @SpaceIm @jgsogo I just realized that my attempts to use boost/1.77 in some new work may be failing because I'm using the CCI recipe for that, and I think I need these changes (to use VS 2019 with toolset 141).

What can we do to resurrect this PR?

prince-chrismc · 2021-10-09T00:54:06Z

Rebase and let's see if the build passes!

Translates settings.compiler.toolset settings in the form vNNN to a toolset version, overriding the use of the settings.compiler.version. This allows building with Visual Studio 2019 while using older toolsets.

It appears that if the environment variables are set, B2 will use the compiler set by tools.vcvars() despite the toolset setting. Even without tools.vcvars(), B2 seems to find the compiler and other tools.

Eliminate all the guessing of version numbers and use the calculations and defaults in tools.msvs_toolset() Retain the conversion of the version number to what B2 wants: v141 -> 14.1 for instance.

Use tools.vcvars() unless the user specified a toolset manually.

conan-center-bot · 2021-10-09T14:58:35Z

All green in build 7 (747d9a65e7589369534d72664ad5637ce02a6adc):

boost/1.69.0@:
All packages built successfully! (All logs)
boost/1.70.0@:
All packages built successfully! (All logs)
boost/1.74.0@:
All packages built successfully! (All logs)
boost/1.71.0@:
All packages built successfully! (All logs)
boost/1.72.0@:
All packages built successfully! (All logs)
boost/1.77.0@:
All packages built successfully! (All logs)
boost/1.73.0@:
All packages built successfully! (All logs)
boost/1.75.0@:
All packages built successfully! (All logs)
boost/1.76.0@:
All packages built successfully! (All logs)

prince-chrismc · 2021-10-09T16:12:37Z

Magic! 🧙

datalogics-kam · 2021-10-09T16:15:46Z

🥳 Thanks, everyone!

datalogics-kam changed the title ~~[boost] For Visual Studio, pass some vailues settings.compiler.toolset to B2~~ [boost] For Visual Studio, pass some values of settings.compiler.toolset to B2 Apr 2, 2021

github-actions bot mentioned this pull request Apr 2, 2021

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Apr 2, 2021

ghost mentioned this pull request Apr 13, 2021

- [boost] add new mirror #5209

Merged

4 tasks

This comment has been minimized.

Sign in to view

ghost mentioned this pull request Apr 17, 2021

boost: add boost/1.76.0 + bump b2 #5246

Merged

4 tasks

This was referenced May 3, 2021

Boost: remove Bintray download + bump dep #5401

Merged

Boost: fix error when building without fiber + improve stacktrace support #5420

Merged

This was referenced May 18, 2021

boost: Improve option for i18n backend #5553

Merged

boost: fix with_stacktrace_backtrace for Macos & MinGW + bump dependencies #5577

Merged

Boost: Treat empty CXX, AR, RANLIB env as undefined #5593

Merged

ghost mentioned this pull request May 26, 2021

Boost.python requires numpy. Fix function _run_python_script(). #5643

Merged

4 tasks

ghost mentioned this pull request Jun 16, 2021

fixes #5816: boost shared build failed with MingW due to .dll.a files #5920

Merged

4 tasks

stale bot added stale and removed stale labels Jun 25, 2021

ghost mentioned this pull request Jul 2, 2021

[boost] Apply patch to fix https://github.com/boostorg/graph/issues/268 #6132

Closed

This was referenced Jul 26, 2021

[boost] fix library name for custom namespace and custom buildid cases #6510

Merged

[boost] Pass sanitizer settings to b2 #6513

Closed

SSE4 closed this Jul 27, 2021

SSE4 reopened this Jul 27, 2021

ghost mentioned this pull request Aug 19, 2021

boost: update to 1.77.0 (#6872) #6929

Merged

4 tasks

prince-chrismc mentioned this pull request Aug 21, 2021

core: always display prs with no reivews prince-chrismc/conan-center-index-pending-review#24

Merged

prince-chrismc reviewed Aug 22, 2021

View reviewed changes

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Aug 24, 2021

ghost mentioned this pull request Sep 2, 2021

- [boost] fix libiconv detection (needed by boost locale) for iOS, Android #7146

Merged

4 tasks

This was referenced Sep 11, 2021

#7244 numa option is deleted if Boost fibre is disabled #7248

Closed

boost: fixed stacktrace_windbg* components, improved stacktrace test. #7281

Merged

Define boost::system as header-only component #7290

Merged

ghost mentioned this pull request Sep 20, 2021

- [boost] fix (shared) NUMA #7348

Merged

4 tasks

This was referenced Oct 1, 2021

boost: ostracize boost_system #7482

Merged

boost: Adds with_stacktrace_noop option #7503

Closed

datalogics-kam added 4 commits October 9, 2021 00:37

boost: Support settings.compiler.toolset for MSVC

3ac8445

Translates settings.compiler.toolset settings in the form vNNN to a toolset version, overriding the use of the settings.compiler.version. This allows building with Visual Studio 2019 while using older toolsets.

boost: Don't use tools.vcvars() if a toolset is specified

da8ebc5

It appears that if the environment variables are set, B2 will use the compiler set by tools.vcvars() despite the toolset setting. Even without tools.vcvars(), B2 seems to find the compiler and other tools.

boost: Make _toolset_version use msvs_toolset()

7a07321

Eliminate all the guessing of version numbers and use the calculations and defaults in tools.msvs_toolset() Retain the conversion of the version number to what B2 wants: v141 -> 14.1 for instance.

boost: Fix choice of using tools.vcvars().

747d9a6

Use tools.vcvars() unless the user specified a toolset manually.

conan-center-bot removed the Failed label Oct 9, 2021

madebr approved these changes Oct 9, 2021

View reviewed changes

SSE4 approved these changes Oct 9, 2021

View reviewed changes

SpaceIm approved these changes Oct 9, 2021

View reviewed changes

conan-center-bot merged commit f7e314e into conan-io:master Oct 9, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[boost] For Visual Studio, pass some values of settings.compiler.toolset to B2 #5119

[boost] For Visual Studio, pass some values of settings.compiler.toolset to B2 #5119

datalogics-kam commented Apr 2, 2021 •

edited

Loading

ghost commented Apr 2, 2021 •

edited by ghost

Loading

This comment has been minimized.

datalogics-kam commented Apr 2, 2021

This comment has been minimized.

datalogics-kam commented Apr 13, 2021

stale bot commented Jun 25, 2021

prince-chrismc Aug 22, 2021

prince-chrismc commented Aug 22, 2021

This comment has been minimized.

datalogics-kam commented Aug 24, 2021

prince-chrismc commented Aug 25, 2021

prince-chrismc commented Aug 25, 2021

datalogics-kam commented Oct 9, 2021

prince-chrismc commented Oct 9, 2021

conan-center-bot commented Oct 9, 2021

prince-chrismc commented Oct 9, 2021

datalogics-kam commented Oct 9, 2021

[boost] For Visual Studio, pass some values of settings.compiler.toolset to B2 #5119

[boost] For Visual Studio, pass some values of settings.compiler.toolset to B2 #5119

Conversation

datalogics-kam commented Apr 2, 2021 • edited Loading

ghost commented Apr 2, 2021 • edited by ghost Loading

This comment has been minimized.

datalogics-kam commented Apr 2, 2021

This comment has been minimized.

datalogics-kam commented Apr 13, 2021

stale bot commented Jun 25, 2021

prince-chrismc Aug 22, 2021

Choose a reason for hiding this comment

prince-chrismc commented Aug 22, 2021

This comment has been minimized.

datalogics-kam commented Aug 24, 2021

prince-chrismc commented Aug 25, 2021

prince-chrismc commented Aug 25, 2021

datalogics-kam commented Oct 9, 2021

prince-chrismc commented Oct 9, 2021

conan-center-bot commented Oct 9, 2021

prince-chrismc commented Oct 9, 2021

datalogics-kam commented Oct 9, 2021

datalogics-kam commented Apr 2, 2021 •

edited

Loading

ghost commented Apr 2, 2021 •

edited by ghost

Loading