- [boost] fix libiconv detection (needed by boost locale) for iOS, Android

[SSE4]

closes: #6490
closes: #3992
closes: #7114
closes: #7159
closes: #5265

Specify library name and version: boost/all

/cc @grafikrobot

This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!

---

• I've read the guidelines for contributing.
• I've followed the PEP8 style guides for Python code in the recipes.
• I've used the latest Conan client version.
• I've tried at least one configuration locally with the
  conan-center hook activated.

[ghost]

I detected other pull requests that are modifying boost/all recipe:

• boost: update to 1.77.0 (#6872) #6929
• [boost] Apply patch to fix https://github.com/boostorg/graph/issues/268 #6132
• [boost] For Visual Studio, pass some values of settings.compiler.toolset to B2 #5119
• boost: use clang-win toolset when compiler=Visual Studio and compiler.toolset=ClangCL #4749

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

[grafikrobot]

Having someone create a corresponding PR in upstream B2 would be nice too (https://github.com/bfgroup/b2/pulls)

[SSE4]

Having someone create a corresponding PR in upstream B2 would be nice too (https://github.com/bfgroup/b2/pulls)

opened one: bfgroup/b2#83

[dmn-star]

stacktrace again. :-) @SSE4 What do you think, should we simple disable stacktrace for ARM?

#6929 (comment)

[SSE4]

stacktrace again. :-) @SSE4 What do you think, should we simple disable stacktrace for ARM?

#6929 (comment)

I will take a look again tomorrow. AFAIK the error was suspicious and I wasn't able to reproduce, but let's check if I can do anything about it.

[SSE4]

okay, I cannot reproduce the problem locally, so will try to run some tests to understand on what's going on...

first off, CMAKE_SHARED_LIBRARY_RUNTIME_C_FLAG (doesn't seem to be documented) is expected to be defined in Modules/Platform/Darwin.cmake:

 50 if(NOT "${_CURRENT_OSX_VERSION}" VERSION_LESS "10.5")
 51   set(CMAKE_SHARED_LIBRARY_RUNTIME_C_FLAG "-Wl,-rpath,")
 52 endif()

so, it's conditional on _CURRENT_OSX_VERSION, where is it defined? in Modules/Platform/Darwin-initialize.cmake
(NOTE: 10.5 is Leopard which is from 2009, more than 10 years ago, unlikely to be used nowadays)

 15 execute_process(COMMAND sw_vers -productVersion
 16   OUTPUT_VARIABLE CURRENT_OSX_VERSION
 17   OUTPUT_STRIP_TRAILING_WHITESPACE)
...
 50 string(REGEX REPLACE "^([0-9]+\\.[0-9]+).*$" "\\1"
 51   _CURRENT_OSX_VERSION "${CURRENT_OSX_VERSION}")

so, it's basically parsed version from sw_vers -productVersion, what is it?
seems to be a small utility to report macOS version, e.g. on my machine it prints:

$ sw_vers -productVersion
11.5.2

I'll check what does it report on CI, as well as all these CMake variables and let you know.

[SSE4]

okay, at least in dummy project output is normal:

----Running------
> cmake --version
-----------------
cmake version 3.19.6

CMake suite maintained and supported by Kitware (kitware.com/cmake).

----Running------
> sw_vers -productVersion
-----------------
11.2.3


-- CURRENT_OSX_VERSION 11.2.3
-- _CURRENT_OSX_VERSION 11.2
-- CMAKE_SHARED_LIBRARY_RUNTIME_C_FLAG 
-- _CURRENT_OSX_VERSION >= 10.5

it might be conan generator messes something up... checking in boost now

okay, I see CMAKE_SHARED_LIBRARY_RUNTIME_C_FLAG isn't set in CI...
for me locally it's set:

-- CURRENT_OSX_VERSION 11.5.2
-- _CURRENT_OSX_VERSION 11.5
-- CMAKE_SHARED_LIBRARY_RUNTIME_C_FLAG -Wl,-rpath,
-- _CURRENT_OSX_VERSION >= 10.5

[SSE4]

okay, this is definitely a CMake issue...
I can reproduce the same output running 3.19.6 locally:

-- CURRENT_OSX_VERSION 11.5.2
-- _CURRENT_OSX_VERSION 11.5
-- CMAKE_SHARED_LIBRARY_RUNTIME_C_FLAG
-- _CURRENT_OSX_VERSION >= 10.5

checking more versions, I see that 3.20.0 doesn't work, but 3.20.1 works.
and here are the commits fixing it:
https://gitlab.kitware.com/cmake/cmake/-/commit/4aed96e2309e64571aabfda263b3ca4c4f62d619
https://gitlab.kitware.com/cmake/cmake/-/commit/1af23c4de2c7d58c06171d70b37794b5c860d5f4

TLDR: we need to upgrade CMake on macOS at least to 3.20.1.

[dmn-star]

I can reproduce the problem locally but with a different error message (maybe CCI forces new toolchain?). It has also not worked for iOS/Android for a long time and now not for Apple M1. Maybe a cross compile issue?

Cross-build from 'Macos:x86_64' to 'Macos:armv8

boost/1.76.0: Applying build-requirement: b2/4.5.0
boost/1.76.0: Building your package in /Users/dmn/.conan/data/boost/1.76.0///build/a731471530a71672c8c4f825a0c8e289720899b3
boost/1.76.0: Generator txt created conanbuildinfo.txt
boost/1.76.0: Aggregating env generators
[HOOK - conan-center.py] pre_build(): [FPIC MANAGEMENT (KB-H007)] OK. 'fPIC' option found and apparently well managed
[HOOK - conan-center.py] pre_build(): [FPIC MANAGEMENT (KB-H007)] OK
boost/1.76.0: Calling build()
WARN: replace_in_file didn't find pattern '$(>) > $(<)' in '/Users/dmn/.conan/data/boost/1.76.0///source/source_subfolder/libs/stacktrace/build/Jamfile.v2' file.
boost/1.76.0: WARN: Patching user-config.jam
boost/1.76.0: WARN:
using zlib : 1.2.11 : "/Users/dmn/.conan/data/zlib/1.2.11///package/7d8b6355b5c6cbe0cf6a4adff1ada79ee8d024ab/include" "/Users/dmn/.conan/data/zlib/1.2.11///package/7d8b6355b5c6cbe0cf6a4adff1ada79ee8d024ab/lib" z ;
using bzip2 : 1.0.8 : "/Users/dmn/.conan/data/bzip2/1.0.8///package/3618e51d87eda0dd9a19e9f8804361cfadaaaa29/include" "/Users/dmn/.conan/data/bzip2/1.0.8///package/3618e51d87eda0dd9a19e9f8804361cfadaaaa29/lib" bz2 ;
using "clang-darwin" : : /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++ -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.1.sdk -arch arm64 :
"/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ar" "/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib" "-I/Users/dmn/.conan/data/libbacktrace/cci.20210118///package/7d8b6355b5c6cbe0cf6a4adff1ada79ee8d024ab/include" "-L/Users/dmn/.conan/data/libbacktrace/cci.20210118///package/7d8b6355b5c6cbe0cf6a4adff1ada79ee8d024ab/lib" ;
boost/1.76.0: Cross building, detecting compiler...
boost/1.76.0: Cross building flags: []
boost/1.76.0: WARN: b2 -q numa=on target-os=darwin architecture=arm address-model=64 binary-format=mach-o abi=aapcs --layout=system --user-config=/Users/dmn/.conan/data/boost/1.76.0///source/source_subfolder/tools/build/user-config.jam -sNO_ZLIB=0 -sNO_BZIP2=0 -sNO_LZMA=1 -sNO_ZSTD=1 boost.locale.icu=off --disable-icu boost.locale.iconv=off --disable-iconv threading=multi visibility=hidden link=static variant=release --with-atomic --with-chrono --with-container --with-context --with-contract --with-coroutine --with-date_time --with-exception --with-fiber --with-filesystem --with-graph --with-iostreams --with-json --with-math --with-nowide --with-program_options --with-random --with-regex --with-serialization --with-stacktrace --with-system --with-test --with-thread --with-timer --with-type_erasure --with-wave toolset=clang-darwin cxxflags=-std=c++14 pch=on linkflags="-stdlib=libc++" cxxflags="-fPIC -stdlib=libc++ -mios-version-min=13.0 -DBOOST_STACKTRACE_ADDR2LINE_LOCATION=/usr/bin/addr2line" install --prefix=/Users/dmn/.conan/data/boost/1.76.0///package/a731471530a71672c8c4f825a0c8e289720899b3 -j12 --abbreviate-paths -d0 --debug-configuration --build-dir="/Users/dmn/.conan/data/boost/1.76.0///build/a731471530a71672c8c4f825a0c8e289720899b3"
notice: found boost-build.jam at /Users/dmn/.conan/data/boost/1.76.0///source/source_subfolder/boost-build.jam
notice: loading B2 from /Users/dmn/.conan/data/boost/1.76.0///source/source_subfolder/tools/build/src/bootstrap.jam
warning: mismatched versions of B2 engine and core
warning: B2 engine (b2) is 4.5.0
warning: B2 core (at /Users/dmn/.conan/data/boost/1.76.0///source/source_subfolder/tools/build/src) is 4.4-git
notice: Searching '/etc' '/Users/dmn' '/Users/dmn/.conan/data/boost/1.76.0///source/source_subfolder/tools/build/src' '/Users/dmn/.conan/data/boost/1.76.0///source/source_subfolder/tools/build/src/kernel' '/Users/dmn/.conan/data/boost/1.76.0///source/source_subfolder/tools/build/src/util' '/Users/dmn/.conan/data/boost/1.76.0///source/source_subfolder/tools/build/src/build' '/Users/dmn/.conan/data/boost/1.76.0///source/source_subfolder/tools/build/src/tools' '/Users/dmn/.conan/data/boost/1.76.0///source/source_subfolder/tools/build/src/contrib' '/Users/dmn/.conan/data/boost/1.76.0///source/source_subfolder/tools/build/src/.' for site-config configuration file 'site-config.jam'.
notice: Configuration file 'site-config.jam' not found in '/etc' '/Users/dmn' '/Users/dmn/.conan/data/boost/1.76.0///source/source_subfolder/tools/build/src' '/Users/dmn/.conan/data/boost/1.76.0///source/source_subfolder/tools/build/src/kernel' '/Users/dmn/.conan/data/boost/1.76.0///source/source_subfolder/tools/build/src/util' '/Users/dmn/.conan/data/boost/1.76.0///source/source_subfolder/tools/build/src/build' '/Users/dmn/.conan/data/boost/1.76.0///source/source_subfolder/tools/build/src/tools' '/Users/dmn/.conan/data/boost/1.76.0///source/source_subfolder/tools/build/src/contrib' '/Users/dmn/.conan/data/boost/1.76.0///source/source_subfolder/tools/build/src/.'.
notice: Loading explicitly specified user configuration file:
/Users/dmn/.conan/data/boost/1.76.0///source/source_subfolder/tools/build/user-config.jam
notice: Searching '/Users/dmn/.conan/data/boost/1.76.0///source/source_subfolder/tools/build' for user-config configuration file 'user-config.jam'.
notice: Loading user-config configuration file 'user-config.jam' from '/Users/dmn/.conan/data/boost/1.76.0///source/source_subfolder/tools/build'.
notice: [zlib] Using pre-installed library
notice: [zlib] Condition
notice: [bzip2] Using pre-installed library
notice: [bzip2] Condition
notice: will use '/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++' '-isysroot' '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.1.sdk' '-arch' 'arm64' for clang-darwin, condition clang-12.0
notice: [zlib] zlib is already configured
notice: [bzip2] bzip is already configured
notice: iostreams: not using lzma compression
notice: iostreams: not using zstd compression
notice: [python-cfg] Configuring python...
notice: [python-cfg] Checking interpreter command "python"...
notice: [python-cfg] running command 'python -c "from sys import *; print('version=%d.%d\nplatform=%s\nprefix=%s\nexec_prefix=%s\nexecutable=%s' % (version_info[0],version_info[1],platform,prefix,exec_prefix,executable))" 2>&1'
notice: [python-cfg] ...requested configuration matched!
notice: [python-cfg] Details of this Python configuration:
notice: [python-cfg] interpreter command: "python"
notice: [python-cfg] include path: "/Users/dmn/.asdf/installs/python/3.9.1/include/python3.9"
notice: [python-cfg] library path: "/Users/dmn/.asdf/installs/python/3.9.1/lib/python3.9/config" "/Users/dmn/.asdf/installs/python/3.9.1/lib"
notice: [python-cfg] Checking for NumPy...
notice: [python-cfg] running command 'python -c "import sys; sys.stderr = sys.stdout; import numpy; print(numpy.get_include())"'
notice: [python-cfg] NumPy disabled. Reason:
notice: [python-cfg] python -c "import sys; sys.stderr = sys.stdout; import numpy; print(numpy.get_include())" aborted with
notice: [python-cfg] Traceback (most recent call last):
File "", line 1, in
ModuleNotFoundError: No module named 'numpy'
notice: [python-cfg] no framework directory found; using library path
Performing configuration checks

- default address-model    : 64-bit [1]
- default architecture     : arm [1]
- C++11 mutex              : yes [2]
- lockfree boost::atomic_flag : no [2]
- has stat::st_mtim        : no [2]
- has stat::st_mtimensec   : no [2]
- has stat::st_mtimespec   : yes [2]
- has stat::st_birthtim    : no [2]
- has stat::st_birthtimensec : no [2]
- has stat::st_birthtimespec : yes [2]
- has statx                : no [2]
- has statx syscall        : no [2]
- cxx11_auto_declarations  : yes [2]
- cxx11_constexpr          : yes [2]
- cxx11_defaulted_functions : yes [2]
- cxx11_final              : yes [2]
- cxx11_hdr_mutex          : yes [2]
- cxx11_hdr_tuple          : yes [2]
- cxx11_lambdas            : yes [2]
- cxx11_noexcept           : yes [2]
- cxx11_nullptr            : yes [2]
- cxx11_rvalue_references  : yes [2]
- cxx11_template_aliases   : yes [2]
- cxx11_thread_local       : yes [2]
- cxx11_variadic_templates : yes [2]
- has_icu builds           : no [2]
- zlib                     : no [3]
- bzip2                    : no [3]
- cxx11_decltype           : yes [2]
- cxx11_basic_alignas      : yes [2]
- gcc visibility           : yes [2]
- sfinae_expr              : yes [2]
- cxx11_unified_initialization_syntax : yes [2]
- cxx11_hdr_initializer_list : yes [2]
- cxx11_hdr_chrono         : yes [2]
- cxx11_numeric_limits     : yes [2]
- cxx11_hdr_array          : yes [2]
- cxx11_hdr_atomic         : yes [2]
- cxx11_hdr_type_traits    : yes [2]
- cxx11_allocator          : yes [2]
- cxx11_explicit_conversion_operators : yes [2]
- long double support      : yes [2]
- cxx11_static_assert      : yes [2]
- std::fstream is moveable and swappable : yes [2]
- Has Large File Support   : no [2]
- libbacktrace builds      : no [2]
- libbacktrace builds      : no [4]
- addr2line builds         : no [2]
- addr2line builds         : no [4]
- WinDbg builds            : no [2]
- WinDbg builds            : no [4]
- WinDbgCached builds      : no [2]
- WinDbgCached builds      : no [4]
- BOOST_COMP_GNUC >= 4.3.0 : no [2]

[1] clng-12.0
[2] clng-drwn-12.0/rls/abi-apcs/bst.l-off/bst.l-off/lnk-sttc/nm-on/pythn-3.9/thrdp-pthrd/thrd-mlt/vsblt-hdn
[3] lnk-sttc
[4] clng-drwn-12.0/rls/abi-apcs/bst.l-off/bst.l-off/bld-no/lnk-sttc/nm-on/pythn-3.9/thrdp-pthrd/thrd-mlt/vsblt-hdn

Component configuration:

- atomic                   : building
- chrono                   : building
- container                : building
- context                  : building
- contract                 : building
- coroutine                : building
- date_time                : building
- exception                : building
- fiber                    : building
- filesystem               : building
- graph                    : building
- graph_parallel           : not building
- headers                  : not building
- iostreams                : building
- json                     : building
- locale                   : not building
- log                      : not building
- math                     : building
- mpi                      : not building
- nowide                   : building
- program_options          : building
- python                   : not building
- random                   : building
- regex                    : building
- serialization            : building
- stacktrace               : building
- system                   : building
- test                     : building
- thread                   : building
- timer                    : building
- type_erasure             : building
- wave                     : building

boost/1.76.0: Package 'a731471530a71672c8c4f825a0c8e289720899b3' built
boost/1.76.0: Build folder /Users/dmn/.conan/data/boost/1.76.0///build/a731471530a71672c8c4f825a0c8e289720899b3
boost/1.76.0: Generated conaninfo.txt
boost/1.76.0: Generated conanbuildinfo.txt
boost/1.76.0: Generating the package
boost/1.76.0: Package folder /Users/dmn/.conan/data/boost/1.76.0///package/a731471530a71672c8c4f825a0c8e289720899b3
boost/1.76.0: Calling package()
[HOOK - conan-center.py] post_package(): [PACKAGE LICENSE (KB-H012)] OK
[HOOK - conan-center.py] post_package(): [DEFAULT PACKAGE LAYOUT (KB-H013)] OK
[HOOK - conan-center.py] post_package(): [MATCHING CONFIGURATION (KB-H014)] OK
[HOOK - conan-center.py] post_package(): [SHARED ARTIFACTS (KB-H015)] OK
[HOOK - conan-center.py] post_package(): [PC-FILES (KB-H020)] OK
[HOOK - conan-center.py] post_package(): [CMAKE-MODULES-CONFIG-FILES (KB-H016)] OK
[HOOK - conan-center.py] post_package(): [PDB FILES NOT ALLOWED (KB-H017)] OK
[HOOK - conan-center.py] post_package(): [LIBTOOL FILES PRESENCE (KB-H018)] OK
[HOOK - conan-center.py] post_package(): [MS RUNTIME FILES (KB-H021)] OK
boost/1.76.0 package(): Packaged 1 '.txt' file: LICENSE_1_0.txt
boost/1.76.0 package(): Packaged 14349 '.hpp' files
boost/1.76.0 package(): Packaged 147 '.h' files
boost/1.76.0 package(): Packaged 17 files
boost/1.76.0 package(): Packaged 253 '.ipp' files
boost/1.76.0 package(): Packaged 2 '.inc' files: strict_cpp_re.inc, cpp_re.inc
boost/1.76.0 package(): Packaged 36 '.a' files
boost/1.76.0: Package 'a731471530a71672c8c4f825a0c8e289720899b3' created
boost/1.76.0: Created package revision b1432d1ab16b3dfa65f13ab958ee3642
boost/1.76.0: WARN: Boost component 'stacktrace_addr2line' is missing libraries. Try building boost with '-o boost:without_stacktrace_addr2line'. (Option is not guaranteed to exist)
boost/1.76.0: WARN: Boost component 'stacktrace_backtrace' is missing libraries. Try building boost with '-o boost:without_stacktrace_backtrace'. (Option is not guaranteed to exist)
ERROR: boost/1.76.0: Error in package_info() method, line 1522
raise ConanException("These libraries were expected to be built, but were not built: {}".format(non_built))
ConanException: These libraries were expected to be built, but were not built: {'boost_stacktrace_backtrace', 'boost_stacktrace_addr2line'}

[SSE4]

@dmn-star let's check, I was told we can't upgrade CMake in CCI right away, so we have to use a workaround with build_requires("cmake/3.20.1") for M1. hopefully, CI will be happy after that.
(the workaround has some downsides, e.g. it can conflict with profile with build requires, but right now there is no better solution to unblock boost, besides disallowing M1 boost entirely. I'd say build requires is least evil).

[dmn-star]

I also noticed.

Performing configuration checks
- libbacktrace builds : no [2]
- libbacktrace builds : no [4]
- addr2line builds : no [2]
- addr2line builds : no [4]
- WinDbg builds : no [2]
- WinDbg builds : no [4]
- WinDbgCached builds : no [2]
- WinDbgCached builds : no [4]

@SSE4 But as you can see, I don't use a CMake toolchain yet.

[SSE4]

Mac with_stacktrace_backtrace=False works
iOS & Catalyst test package build failed + lots of "skipping already existing target" now

/Users/dmn/.conan/data/boost/1.76.0///package/d947e498cffc705c002fb7ff45475bb1caf297ef/include/boost/stacktrace/detail/collect_unwind.ipp:33:2: error: "Boost.Stacktrace requires _Unwind_Backtrace function. Define _GNU_SOURCE macro or BOOST_STACKTRACE_GNU_SOURCE_NOT_REQUIRED if _Unwind_Backtrace is available without _GNU_SOURCE."
#error "Boost.Stacktrace requires _Unwind_Backtrace function. Define _GNU_SOURCE macro or BOOST_STACKTRACE_GNU_SOURCE_NOT_REQUIRED if _Unwind_Backtrace is available without _GNU_SOURCE."
^
1 error generated.
[14/28] Building CXX object CMakeFiles/regex_exe.dir/regex.cpp.o
ninja: build stopped: subcommand failed.
ERROR: boost/1.76.0 (test package): Error in build() method, line 45
cmake.build()
ConanException: Error 1 while executing cmake --build '/Users/dmn/dev/temp/sse4/conan-center-index/recipes/boost/all/test_package/build/de1c41fb7d86598922c27d4fdbb33643fce87de7'

yeah, I had this error as well.
we define macro BOOST_STACKTRACE_GNU_SOURCE_NOT_REQUIRED here:

conan-center-index/recipes/boost/all/conanfile.py

Line 1549 in f833d02

self.cpp_info.components["stacktrace"].defines.append("BOOST_STACKTRACE_GNU_SOURCE_NOT_REQUIRED")

for the stacktrace component, at least.
but I think stacktrace_addr2line_exe shouldn't be built for iOS/Catalyst at all, as well as Boost::stacktrace_addr2line component shouldn't be provided.

[dmn-star]

agree.

PS: Android build OK

-- Build files have been written to: /Users/dmn/dev/temp/sse4/conan-center-index/recipes/boost/all/test_package/build/e68bc1eac8c9d2d506d3275c11b577f6c2c2b1f1
Calling CMake via Android-NDK wrapper
[28/28] Linking CXX executable bin/regex_exe
boost/1.76.0 (test package): Running test()
.../conan-center-index on  boost_iconv_ios

conan create ./recipes/boost/all boost/1.76.0@ --build=missing --profile:host /Users/dmn/dev/github/dmn-star/conan/profiles/android --profile:build /Users/dmn/dev/github/dmn-star/conan/profiles/mac

[dmn-star]

Checked this morning "is being built".
Have now checked again "is being built".

My old PC needs 3min. to build boost from scratch. Or does CCI have a weekend as well? :-)

[SpaceIm]

I've tried cross-build to iOS in boost/1.76.0 with this PR, and it works now.

[conan-center-bot]

All green in build 10 (23c0989b1248db31d7b0b10cae2231b2a0063e25):

• boost/1.69.0@:
  All packages built successfully! (All logs)

• boost/1.70.0@:
  All packages built successfully! (All logs)

• boost/1.71.0@:
  All packages built successfully! (All logs)

• boost/1.72.0@:
  All packages built successfully! (All logs)

• boost/1.76.0@:
  All packages built successfully! (All logs)

• boost/1.73.0@:
  All packages built successfully! (All logs)

• boost/1.74.0@:
  All packages built successfully! (All logs)

• boost/1.75.0@:
  All packages built successfully! (All logs)

[SSE4]

I've tried cross-build to iOS in boost/1.76.0 with this PR, and it works now.

interesting... thanks a lot for checking!

[dmn-star]

Thanks to you for the excellent work. 👍