#7244 numa option is deleted if Boost fibre is disabled

[wdobbe]

Specify library name and version: boost/1.77.0

Resolves #7244.

When option without_fiber is set to True, option numa is deleted in the recipe. But currently the recipe still tries to change it value without checking if the option exists.

---

• I've read the guidelines for contributing.
• I've followed the PEP8 style guides for Python code in the recipes.
• I've used the latest Conan client version.
• I've tried at least one configuration locally with the
  conan-center hook activated.

[ghost]

I detected other pull requests that are modifying boost/all recipe:

• Define boost::system as header-only component #7290
• boost: fixed stacktrace_windbg* components, improved stacktrace test. #7281
• [boost] Apply patch to fix https://github.com/boostorg/graph/issues/268 #6132
• [boost] For Visual Studio, pass some values of settings.compiler.toolset to B2 #5119
• boost: use clang-win toolset when compiler=Visual Studio and compiler.toolset=ClangCL #4749

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

[conan-center-bot]

All green in build 1 (c15554da7144322df8ef37c51dec2a54cd7f61f2):

• boost/1.70.0@:
  All packages built successfully! (All logs)

• boost/1.74.0@:
  All packages built successfully! (All logs)

• boost/1.73.0@:
  All packages built successfully! (All logs)

• boost/1.69.0@:
  All packages built successfully! (All logs)

• boost/1.71.0@:
  All packages built successfully! (All logs)

• boost/1.72.0@:
  All packages built successfully! (All logs)

• boost/1.76.0@:
  All packages built successfully! (All logs)

• boost/1.75.0@:
  All packages built successfully! (All logs)

• boost/1.77.0@:
  All packages built successfully! (All logs)

[madebr]

self.options.numa is removed in the configure method.

conan-center-index/recipes/boost/all/conanfile.py

Lines 381 to 382 in 011f6e2

	if self.options.without_fiber:
	del self.options.numa

The lines you're wanting to change here are in the config_options method.

conan-center-index/recipes/boost/all/conanfile.py

Lines 292 to 294 in 011f6e2

	if self.settings.compiler == "Visual Studio":
	# Shared builds of numa do not link on Visual Studio due to missing symbols
	self.options.numa = False

config_options is run before configure.
So there is no problem.

[madebr]

See #7248 (comment)

I think this pr is invalid.

[wdobbe]

@madebr I was also surprised that I got an error message in the config_options section.

But using the new Boost recipe still broke my build with the following error message (full log in linked issue):

ERROR: boost/1.77.0: Error in config_options() method, line 294
		self.options.numa = False
	ConanException: option 'numa' doesn't exist

Can you explain then why I get that error when 'without_fiber' is True ?

[madebr]

What command is failing for you?
I ran the following commands and conan began building boost without showing an error.

conan create . boost/1.77.0@ -o boost:without_fiber=True -o boost:numa=False
conan create . boost/1.77.0@ -o boost:without_fiber=True -o boost:numa=True
conan create . boost/1.77.0@ -o boost:without_fiber=False -o boost:numa=False
conan create . boost/1.77.0@ -o boost:without_fiber=False -o boost:numa=True

Using gcc@Linux.

Configuration for profile default:

[settings]
os=Linux
os_build=Linux
arch=x86_64
arch_build=x86_64
compiler=gcc
compiler.version=11
compiler.libcxx=libstdc++11
build_type=Release
[options]
[conf]
[build_requires]
[env]
CC=/usr/bin/gcc
CXX=/usr/bin/g++

[SSE4]

probably, it makes sense to fix boost shared=True + numa build instead.
there are many reports about it:
#4339
#4950

[wdobbe]

I'll reproduce it tomorrow and copy the exact command I used.

[dmn-star]

probably, it makes sense to fix boost shared=True + numa build instead.

That would be very nice. Then I could finally get rid of my workaround (#4339 (comment)).

[wdobbe]

What command is failing for you?
I ran the following commands and conan began building boost without showing an error.

conan create . boost/1.77.0@ -o boost:without_fiber=True -o boost:numa=False
conan create . boost/1.77.0@ -o boost:without_fiber=True -o boost:numa=True
conan create . boost/1.77.0@ -o boost:without_fiber=False -o boost:numa=False
conan create . boost/1.77.0@ -o boost:without_fiber=False -o boost:numa=True

Using gcc@Linux.

On Linux you will not see this problem because the line where the error is reported is executed only when compiling with VS2019:

if self.settings.compiler == "Visual Studio":
            # Shared builds of numa do not link on Visual Studio due to missing symbols
            self.options.numa = Fals

[madebr]

I'm on Windows now and trying those 4 option combinations.
In all cases, conan began building just fine.

Please post the complete conan create boost/1.77.0@ command that is failing.

[wdobbe]

Yes, I'm trying to reproduce it myself now.

[wdobbe]

Well, I haven't been able to reproduce the reported problem anymore.
Sorry for the false alarm, I don't know why I got that error, maybe an old recipe in the local cache.