-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update POCO CMake wrapper cmake_minimum_required #6028
Conversation
POCO 1.10.1 already requires 3.5.0. See also https://github.com/pocoproject/poco/blob/a9a3962590d48298055bba5d0b4c8794dedf5e13/CMakeLists.txt#L1 .
This comment has been minimized.
This comment has been minimized.
@uilianries Thanks for your review! Would you like to help on ci issue? I'm unsure what to do now. |
@@ -1,4 +1,4 @@ | |||
cmake_minimum_required(VERSION 2.8.12) | |||
cmake_minimum_required(VERSION 3.5.0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this change is necessary. AFAIK CMake is respecting all minimum versions from all subprojects. This version should only be about the minimum version of this CMake file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope. If it is set as 2.8.12
then CMP0025
isn't set by default and build with Clang 12.0.0 will failed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is true the policies are only set once at the root level, I learnt this recently myself.
The version requirements to increase however
Please read the docs... I improved them in #5962 and would love any suggestions if it's not clear how the CI system works! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tisonkun You will be added to as contributor soon, then your PR will get merged 😊
This comment has been minimized.
This comment has been minimized.
How can I retrigger the CI or push the PR to merge? |
Now that you are added, CI is running it should not be long you are only missing 1 review |
This comment has been minimized.
This comment has been minimized.
I detected other pull requests that are modifying poco/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
@prince-chrismc Hi! What does it mean that it only provides successful logs but say nothing helpful on failures. |
This comment has been minimized.
This comment has been minimized.
There was maintenance done, you seem to have fallen victim to it You'll need to retrigger CI, close the pr wait 10s and then re-open it 🔁 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hi! This is failing consistently in this PR. I don't know if changing the CMake required version changes some policy that bites us... but maybe we can follow some of the leads here:
|
This comment has been minimized.
This comment has been minimized.
Sorry I don't have idea on these information. For the latest report I can see the failure is
... which seems pcre/8.44 missing, which seems irrelevant to this change. |
I've checked it and all the packages are available in ConanCenter: https://c3i.jfrog.io/c3i/misc/summary.html?json=https://c3i.jfrog.io/c3i/misc/logs/TapaholesList/202/pcre/8.44//summary.json I think it was a concurrency issue, this PR took into account a new revision while we were uploading the packages from this PR exactly at the same time, 12 hours ago (#6102). At the moment of looking for the packages in the remote, the new recipe revision was available, but that exact packageID was not ready yet. PS.- We have added |
👍 |
All green in build 9 ( |
Thanks for all of your helps! |
POCO 1.10.1 already requires 3.5.0. See also https://github.com/pocoproject/poco/blob/a9a3962590d48298055bba5d0b4c8794dedf5e13/CMakeLists.txt#L1 .
POCO 1.10.1 already requires 3.5.0.
See also https://github.com/pocoproject/poco/blob/a9a3962590d48298055bba5d0b4c8794dedf5e13/CMakeLists.txt#L1 .
At least on my environment, 3.1 is required for distinguish Clang and AppleClang.
Specify library name and version: poco/1.10.1
This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!
conan-center hook activated.