Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update POCO CMake wrapper cmake_minimum_required #6028

Merged
merged 1 commit into from
Jul 3, 2021
Merged

Update POCO CMake wrapper cmake_minimum_required #6028

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion recipes/poco/all/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 2.8.12)
cmake_minimum_required(VERSION 3.5.0)
Copy link
Contributor

@Croydon Croydon Jun 23, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this change is necessary. AFAIK CMake is respecting all minimum versions from all subprojects. This version should only be about the minimum version of this CMake file.

Copy link
Contributor Author

@tisonkun tisonkun Jun 24, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. If it is set as 2.8.12 then CMP0025 isn't set by default and build with Clang 12.0.0 will failed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is true the policies are only set once at the root level, I learnt this recently myself.

The version requirements to increase however

project(cmake_wrapper)

include(conanbuildinfo.cmake)
Expand Down