Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libusb: bump msys2 + add checks for enable_udev option #6403

Merged
merged 8 commits into from
Jul 19, 2021

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Jul 18, 2021

Specify library name and version: lib/1.0

enable_udev option doesn't work on Android yet because libudev recipe is missing. For the moment it can only work for native build on Linux.
This PR is related to #5675, but doesn't really fix it. It should display a more meaningful message.


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

SpaceIm added 8 commits July 18, 2021 11:43
Prefer to disable default value for Android, and raise if enabled by downstream.
libudev recipe is missing. It works for Linux because we rely on system requirements, but it doesn't help for Android build.
@ghost
Copy link

ghost commented Jul 18, 2021

I detected other pull requests that are modifying libusb/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot
Copy link
Collaborator

All green in build 1 (9f7635793ca09e4507621d7d549ff7a409bbd1b6):

  • libusb/1.0.23@:
    All packages built successfully! (All logs)

  • libusb/1.0.24@:
    All packages built successfully! (All logs)

@SSE4 SSE4 requested a review from uilianries July 19, 2021 06:47
@conan-center-bot conan-center-bot merged commit 1ce3856 into conan-io:master Jul 19, 2021
@SpaceIm SpaceIm deleted the fix/libusb-option branch July 19, 2021 11:15
AndreyMlashkin pushed a commit to AndreyMlashkin/conan-center-index that referenced this pull request Jul 19, 2021
* reorder methods

* raise if enable_udev & Android for the moment

Prefer to disable default value for Android, and raise if enabled by downstream.
libudev recipe is missing. It works for Linux because we rely on system requirements, but it doesn't help for Android build.

* bump msys2

* no os.rename

* use tools.remove_files_by_mask()

* pure C test package

* system requirements depend on build machine

* improve checks of enable_udev option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants