-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libusb: bump msys2 + add checks for enable_udev option #6403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prefer to disable default value for Android, and raise if enabled by downstream. libudev recipe is missing. It works for Linux because we rely on system requirements, but it doesn't help for Android build.
ghost
mentioned this pull request
Jul 18, 2021
I detected other pull requests that are modifying libusb/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
madebr
approved these changes
Jul 18, 2021
intelligide
approved these changes
Jul 18, 2021
SSE4
approved these changes
Jul 19, 2021
AndreyMlashkin
pushed a commit
to AndreyMlashkin/conan-center-index
that referenced
this pull request
Jul 19, 2021
* reorder methods * raise if enable_udev & Android for the moment Prefer to disable default value for Android, and raise if enabled by downstream. libudev recipe is missing. It works for Linux because we rely on system requirements, but it doesn't help for Android build. * bump msys2 * no os.rename * use tools.remove_files_by_mask() * pure C test package * system requirements depend on build machine * improve checks of enable_udev option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: lib/1.0
enable_udev
option doesn't work on Android yet because libudev recipe is missing. For the moment it can only work for native build on Linux.This PR is related to #5675, but doesn't really fix it. It should display a more meaningful message.
conan-center hook activated.