Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libusb: Use systemd/system #905

Closed

Conversation

Croydon
Copy link
Contributor

@Croydon Croydon commented Feb 18, 2020

Specify library name and version: libusb/1.0.23

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot

This comment has been minimized.

@uilianries uilianries mentioned this pull request Feb 26, 2020
4 tasks
@conan-center-bot

This comment has been minimized.

@SSE4 SSE4 added the blocked Affected by an external issue and waiting until it is solved label May 4, 2020
@madebr
Copy link
Contributor

madebr commented Sep 3, 2020

@Croydon
I think this can be closed as we have a libusb/1.0.23 recipe

@Croydon
Copy link
Contributor Author

Croydon commented Sep 3, 2020

@madebr This pr is about getting rid of the direct system requirements the libusb recipe still has

We need libudev in some Conan system package as it is part of systemd, but we don't have one yet

@madebr
Copy link
Contributor

madebr commented Sep 3, 2020

Apologies. My brain shortcuted after reading usb.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@Croydon Croydon changed the title libusb: Use libudev/virtual libusb: Use systemd/system Dec 15, 2020
@Croydon Croydon marked this pull request as draft December 15, 2020 13:27
@Croydon Croydon force-pushed the libusb-use-libudev-virtual branch from 67fcad0 to b1019ed Compare December 15, 2020 13:36
@conan-center-bot
Copy link
Collaborator

Failure in build 7 (b1019ed627ad32d7046e02a4784b192257b57889):

  • Error processing recipe (ref 'libusb/1.0.23'): Linux x86_64, Release, gcc 4.9, libstdc++ . Options: libusb:shared-False
    You are depending on 'systemd/system' but it is not in the repository

@prince-chrismc
Copy link
Contributor

There appears to be a libusb merged #4067

Can this be closed?

@Croydon
Copy link
Contributor Author

Croydon commented Feb 21, 2021

No, this is not about adding libusb, this is about changing from a direct system dependencies on a system package, which did not make it yet over the finish line.

@conan-center-bot
Copy link
Collaborator

Failure in build 8 (b1019ed627ad32d7046e02a4784b192257b57889):

  • libusb/1.0.23@:
    Error running command conan info libusb/1.0.23@ --json {jsonName} -pr {profileName}:

    [settings]
    arch=x86_64
    arch_build=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++
    compiler.version=4.9
    os=Linux
    os_build=Linux
    [options]
    shared=False
    
    ...
    ERROR: Failed requirement 'systemd/system' from 'libusb/1.0.23'
    ERROR: Unable to find 'systemd/system' in remotes
    
    
  • libusb/1.0.24@:
    Error running command conan info libusb/1.0.24@ --json {jsonName} -pr {profileName}:

    [settings]
    arch=x86_64
    arch_build=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++
    compiler.version=4.9
    os=Linux
    os_build=Linux
    [options]
    shared=False
    
    ...
    ERROR: Failed requirement 'systemd/system' from 'libusb/1.0.24'
    ERROR: Unable to find 'systemd/system' in remotes
    
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@ghost ghost mentioned this pull request Mar 4, 2022
4 tasks
@ghost ghost mentioned this pull request Mar 15, 2022
4 tasks
@ghost
Copy link

ghost commented Mar 15, 2022

I detected other pull requests that are modifying libusb/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@ghost ghost mentioned this pull request Mar 30, 2022
4 tasks
@ghost ghost mentioned this pull request Apr 22, 2022
4 tasks
@ghost ghost mentioned this pull request Sep 21, 2022
4 tasks
@ghost ghost mentioned this pull request Jan 1, 2023
3 tasks
@ghost ghost mentioned this pull request Apr 17, 2023
3 tasks
@CLAassistant
Copy link

CLAassistant commented May 18, 2023

CLA assistant check
All committers have signed the CLA.

@valgur
Copy link
Contributor

valgur commented Nov 14, 2023

@RubenRBS @uilianries This one can probably be closed:

def requirements(self):
if self.settings.os == "Linux":
if self.options.enable_udev:
self.requires("libudev/system")

The PR is also permanently stuck in a "pending" state: https://github.com/conan-io/conan-center-index/pulls?q=is%3Apr+status%3Apending+is%3Aopen+sort%3Aupdated-asc

@ericLemanissier ericLemanissier deleted the libusb-use-libudev-virtual branch December 1, 2023 09:09
@jcar87
Copy link
Contributor

jcar87 commented Jan 30, 2024

Closing this as stale - @Croydon please let us know if this is still needed or if this is blocking anything else, and we can reopen it, thanks!

@jcar87 jcar87 closed this Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Affected by an external issue and waiting until it is solved Failed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants