-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libusb should not decide about libudev #9780
libusb should not decide about libudev #9780
Conversation
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
I detected other pull requests that are modifying libusb/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the android check has to stay, because it won't be caught by this https://github.com/conan-io/conan-center-index/pull/9780/files#diff-c4fac46e939f790d8e094b15fd7a91507696349a250f8cd75860ae43af3b921aR64-R67
raise ConanInvalidConfiguration("udev can't be enabled for Android yet, since libudev recipe is missing in CCI.") | ||
if tools.cross_building(self): | ||
raise ConanInvalidConfiguration("udev can't be enabled yet if cross-compiling") | ||
|
||
def build_requirements(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
def build_requirements(self): | |
def validate(self): | |
if self.options.get_safe("enable_udev"): | |
if self.settings.os == "Android": | |
raise ConanInvalidConfiguration("udev can't be enabled for Android yet, since libudev recipe is missing in CCI.") | |
def build_requirements(self): |
on Android, "libudev/system" is not part of the requirements of libusb
The libusb is managing what libudev can and can not do. However, libudev has a package now, where all those limitations should be managed. It was a leftover when moving the SystemPackageTool from libusb to libudev package.
Specify library name and version: libusb/1.0.24
Related to #9773
conan-center hook activated.