Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libusb should not decide about libudev #9780

Merged
merged 2 commits into from
Mar 16, 2022

Conversation

uilianries
Copy link
Member

The libusb is managing what libudev can and can not do. However, libudev has a package now, where all those limitations should be managed. It was a leftover when moving the SystemPackageTool from libusb to libudev package.

Specify library name and version: libusb/1.0.24

Related to #9773


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@ghost
Copy link

ghost commented Mar 15, 2022

I detected other pull requests that are modifying libusb/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot
Copy link
Collaborator

All green in build 1 (12e2aab034cf5d03a2e20c32371462fa7794ac40):

  • libusb/1.0.24@:
    All packages built successfully! (All logs)

  • libusb/1.0.23@:
    All packages built successfully! (All logs)

Copy link
Contributor

@ericLemanissier ericLemanissier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

raise ConanInvalidConfiguration("udev can't be enabled for Android yet, since libudev recipe is missing in CCI.")
if tools.cross_building(self):
raise ConanInvalidConfiguration("udev can't be enabled yet if cross-compiling")

def build_requirements(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def build_requirements(self):
def validate(self):
if self.options.get_safe("enable_udev"):
if self.settings.os == "Android":
raise ConanInvalidConfiguration("udev can't be enabled for Android yet, since libudev recipe is missing in CCI.")
def build_requirements(self):

on Android, "libudev/system" is not part of the requirements of libusb

@conan-center-bot conan-center-bot merged commit 46002c3 into conan-io:master Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants