Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove system_requirements exception for libusb #158

Merged
merged 2 commits into from
Mar 3, 2022

Conversation

Croydon
Copy link
Contributor

@Croydon Croydon commented Feb 16, 2020

I would like to create a "virtual package" for libudev in CCI, which relies on system_requirements to install libudev

The rational for whitelisting it in the first place was because @uilianries and I deemed it to be too low-level. Libudev is part of systemd, but I'm not sure how entangled it is with the rest of systemd

Libusb is currently installing libudev via system_requirements.

Moving it into an own recipe allows

  • that other recipes can use it too
  • if we ever decide to build it ourselves we can "just" replace the logic within the recipe

In general, I still firmly believe that system_requirements should be avoided so we should be careful when whitelisting stuff.

// @SSE4

Blocked by conan-io/conan-center-index#7940

@uilianries
Copy link
Member

@czoido it's another example related to conan-io/conan-center-index#641

uilianries
uilianries previously approved these changes Feb 17, 2020
SSE4
SSE4 previously approved these changes Feb 24, 2020
@jgsogo
Copy link
Contributor

jgsogo commented Aug 10, 2020

Link: conan-io/conan-center-index#2468

@Croydon
Copy link
Contributor Author

Croydon commented Aug 11, 2020

I will update this to remove exception for libusb

All system "versions" are allowed by the hooks anyway

@Croydon Croydon changed the title System requirements: Whitelist libudev instead of libusb @Croydon Remove system_requirements exception for libusb Aug 11, 2020
@Croydon
Copy link
Contributor Author

Croydon commented Aug 11, 2020

This should only get merged after we actually have a system package including libudev, so that the libusb recipe can be updated accordingly

@Croydon Croydon changed the title @Croydon Remove system_requirements exception for libusb [WIP] Remove system_requirements exception for libusb Aug 11, 2020
@Croydon Croydon marked this pull request as draft December 15, 2020 13:51
@Croydon Croydon changed the title [WIP] Remove system_requirements exception for libusb Remove system_requirements exception for libusb Dec 15, 2020
@jgsogo jgsogo dismissed stale reviews from SSE4 and uilianries via ab1b540 August 3, 2021 10:58
@Croydon
Copy link
Contributor Author

Croydon commented Feb 21, 2022

Due to the merge of the default branch, this would now also remove the exception for the backward-cpp recipe. Are we okay with this?

@uilianries
Copy link
Member

uilianries commented Feb 21, 2022

Due to the merge of the default branch, this would now also remove the exception for the backward-cpp recipe. Are we okay with this?

Okay

@Croydon Croydon marked this pull request as ready for review February 27, 2022 09:57
@uilianries uilianries merged commit f1a05b4 into conan-io:master Mar 3, 2022
@Croydon Croydon deleted the patch-1 branch March 3, 2022 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants