-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aravis: Add a new recipe. #8379
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Ready for review. It is technically possible to build shared glib with static MT/MTd runtime with MSVC. However this seems to be unsupported and will cause issues. In this case Similarly we must ensure we only have one copy of glib when it is built static. Based on #7142 I used I think we need something like |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I think what is happening here is that glib tool Any ideas how to fix this? The |
You can wrap the meson calls in tools.RunEnvironment |
This comment has been minimized.
This comment has been minimized.
@ericLemanissier Thanks for the tip.
glib is unpacked in slightly different place ( |
I could reproduce the macOS problem on a local machine. It does indeed seem like a System Integrity Protection problem. Please see the linked issue I created. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I disabled macOS for now as the SIP workaround in conan-io/conan#7324 seems to take some time to get merged. There doesn't seem to be any simple workarounds we can apply at this time. |
@sh0 no problem, we can improve in the future. Thank for your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
All green in build 12 (
|
I'm still looking to get this recipe committed if possible. Any chance of getting this reviewed by anyone? Thanks for your time as always. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been waiting too long 😢
Any improvements can wait for a follow up PR. it looks solid
Looks like I have a bug, prince-chrismc/conan-center-index-pending-review#1 did not advertise your PR. Nothing obvious should have hidden it 😕 |
Specify library name and version: aravis/0.8.19
Aravis is a library for communicating with Genicam based cameras over USB3 and GigE connections.
Introspection doesn't seem to work, but the option flag to enable it was added anyways.
conan-center hook activated.