This repository has been archived by the owner on Jun 12, 2024. It is now read-only.
Green PRs with dismissed or zero Approvals don't appear on the board #33
Assignees
Labels
bug
Something isn't working
Comments
|
conan-io/conan-center-index#9169 (comment) API capturehttps://api.github.com/repos/conan-io/conan-center-index/pulls/9169 {
"url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/9169",
"id": 835439936,
"node_id": "PR_kwDODDMJAM4xy81A",
"html_url": "https://github.com/conan-io/conan-center-index/pull/9169",
"diff_url": "https://github.com/conan-io/conan-center-index/pull/9169.diff",
"patch_url": "https://github.com/conan-io/conan-center-index/pull/9169.patch",
"issue_url": "https://api.github.com/repos/conan-io/conan-center-index/issues/9169",
"number": 9169,
"state": "open",
"locked": false,
"title": "add physfs/3.0.2",
"user": {
"login": "SpaceIm",
"id": 30052553,
"node_id": "MDQ6VXNlcjMwMDUyNTUz",
"avatar_url": "https://avatars.githubusercontent.com/u/30052553?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/SpaceIm",
"html_url": "https://github.com/SpaceIm",
"followers_url": "https://api.github.com/users/SpaceIm/followers",
"following_url": "https://api.github.com/users/SpaceIm/following{/other_user}",
"gists_url": "https://api.github.com/users/SpaceIm/gists{/gist_id}",
"starred_url": "https://api.github.com/users/SpaceIm/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/SpaceIm/subscriptions",
"organizations_url": "https://api.github.com/users/SpaceIm/orgs",
"repos_url": "https://api.github.com/users/SpaceIm/repos",
"events_url": "https://api.github.com/users/SpaceIm/events{/privacy}",
"received_events_url": "https://api.github.com/users/SpaceIm/received_events",
"type": "User",
"site_admin": false
},
"body": "Specify library name and version: **lib/1.0**\r\n\r\nThis is also a good place to share with all of us **why you are submitting this PR** (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!\r\n\r\n---\r\n\r\n- [ ] I've read the [guidelines](https://github.com/conan-io/conan-center-index/blob/master/docs/how_to_add_packages.md) for contributing.\r\n- [ ] I've followed the [PEP8](https://www.python.org/dev/peps/pep-0008/) style guides for Python code in the recipes.\r\n- [ ] I've used the [latest](https://github.com/conan-io/conan/releases/latest) Conan client version.\r\n- [ ] I've tried at least one configuration locally with the\r\n [conan-center hook](https://github.com/conan-io/hooks.git) activated.\r\n",
"created_at": "2022-01-30T17:47:46Z",
"updated_at": "2022-02-02T10:09:56Z",
"closed_at": null,
"merged_at": null,
"merge_commit_sha": "6358e00f33ff54f8a0f6ae044b39f1e0ca9d29f2",
"assignee": null,
"assignees": [
],
"requested_reviewers": [
],
"requested_teams": [
],
"labels": [
],
"milestone": null,
"draft": false,
"commits_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/9169/commits",
"review_comments_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/9169/comments",
"review_comment_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/comments{/number}",
"comments_url": "https://api.github.com/repos/conan-io/conan-center-index/issues/9169/comments",
"statuses_url": "https://api.github.com/repos/conan-io/conan-center-index/statuses/2dbd36d7e6b0635872e5b5dc95cbd642e4d150af",
"head": {
"label": "SpaceIm:new/physfs/3.0.2",
"ref": "new/physfs/3.0.2",
"sha": "2dbd36d7e6b0635872e5b5dc95cbd642e4d150af",
"user": {
"login": "SpaceIm",
"id": 30052553,
"node_id": "MDQ6VXNlcjMwMDUyNTUz",
"avatar_url": "https://avatars.githubusercontent.com/u/30052553?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/SpaceIm",
"html_url": "https://github.com/SpaceIm",
"followers_url": "https://api.github.com/users/SpaceIm/followers",
"following_url": "https://api.github.com/users/SpaceIm/following{/other_user}",
"gists_url": "https://api.github.com/users/SpaceIm/gists{/gist_id}",
"starred_url": "https://api.github.com/users/SpaceIm/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/SpaceIm/subscriptions",
"organizations_url": "https://api.github.com/users/SpaceIm/orgs",
"repos_url": "https://api.github.com/users/SpaceIm/repos",
"events_url": "https://api.github.com/users/SpaceIm/events{/privacy}",
"received_events_url": "https://api.github.com/users/SpaceIm/received_events",
"type": "User",
"site_admin": false
},
"repo": {
"id": 229263186,
"node_id": "MDEwOlJlcG9zaXRvcnkyMjkyNjMxODY=",
"name": "conan-center-index",
"full_name": "SpaceIm/conan-center-index",
"private": false,
"owner": {
"login": "SpaceIm",
"id": 30052553,
"node_id": "MDQ6VXNlcjMwMDUyNTUz",
"avatar_url": "https://avatars.githubusercontent.com/u/30052553?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/SpaceIm",
"html_url": "https://github.com/SpaceIm",
"followers_url": "https://api.github.com/users/SpaceIm/followers",
"following_url": "https://api.github.com/users/SpaceIm/following{/other_user}",
"gists_url": "https://api.github.com/users/SpaceIm/gists{/gist_id}",
"starred_url": "https://api.github.com/users/SpaceIm/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/SpaceIm/subscriptions",
"organizations_url": "https://api.github.com/users/SpaceIm/orgs",
"repos_url": "https://api.github.com/users/SpaceIm/repos",
"events_url": "https://api.github.com/users/SpaceIm/events{/privacy}",
"received_events_url": "https://api.github.com/users/SpaceIm/received_events",
"type": "User",
"site_admin": false
},
"html_url": "https://github.com/SpaceIm/conan-center-index",
"description": "Recipes for the conan-center repository",
"fork": true,
"url": "https://api.github.com/repos/SpaceIm/conan-center-index",
"forks_url": "https://api.github.com/repos/SpaceIm/conan-center-index/forks",
"keys_url": "https://api.github.com/repos/SpaceIm/conan-center-index/keys{/key_id}",
"collaborators_url": "https://api.github.com/repos/SpaceIm/conan-center-index/collaborators{/collaborator}",
"teams_url": "https://api.github.com/repos/SpaceIm/conan-center-index/teams",
"hooks_url": "https://api.github.com/repos/SpaceIm/conan-center-index/hooks",
"issue_events_url": "https://api.github.com/repos/SpaceIm/conan-center-index/issues/events{/number}",
"events_url": "https://api.github.com/repos/SpaceIm/conan-center-index/events",
"assignees_url": "https://api.github.com/repos/SpaceIm/conan-center-index/assignees{/user}",
"branches_url": "https://api.github.com/repos/SpaceIm/conan-center-index/branches{/branch}",
"tags_url": "https://api.github.com/repos/SpaceIm/conan-center-index/tags",
"blobs_url": "https://api.github.com/repos/SpaceIm/conan-center-index/git/blobs{/sha}",
"git_tags_url": "https://api.github.com/repos/SpaceIm/conan-center-index/git/tags{/sha}",
"git_refs_url": "https://api.github.com/repos/SpaceIm/conan-center-index/git/refs{/sha}",
"trees_url": "https://api.github.com/repos/SpaceIm/conan-center-index/git/trees{/sha}",
"statuses_url": "https://api.github.com/repos/SpaceIm/conan-center-index/statuses/{sha}",
"languages_url": "https://api.github.com/repos/SpaceIm/conan-center-index/languages",
"stargazers_url": "https://api.github.com/repos/SpaceIm/conan-center-index/stargazers",
"contributors_url": "https://api.github.com/repos/SpaceIm/conan-center-index/contributors",
"subscribers_url": "https://api.github.com/repos/SpaceIm/conan-center-index/subscribers",
"subscription_url": "https://api.github.com/repos/SpaceIm/conan-center-index/subscription",
"commits_url": "https://api.github.com/repos/SpaceIm/conan-center-index/commits{/sha}",
"git_commits_url": "https://api.github.com/repos/SpaceIm/conan-center-index/git/commits{/sha}",
"comments_url": "https://api.github.com/repos/SpaceIm/conan-center-index/comments{/number}",
"issue_comment_url": "https://api.github.com/repos/SpaceIm/conan-center-index/issues/comments{/number}",
"contents_url": "https://api.github.com/repos/SpaceIm/conan-center-index/contents/{+path}",
"compare_url": "https://api.github.com/repos/SpaceIm/conan-center-index/compare/{base}...{head}",
"merges_url": "https://api.github.com/repos/SpaceIm/conan-center-index/merges",
"archive_url": "https://api.github.com/repos/SpaceIm/conan-center-index/{archive_format}{/ref}",
"downloads_url": "https://api.github.com/repos/SpaceIm/conan-center-index/downloads",
"issues_url": "https://api.github.com/repos/SpaceIm/conan-center-index/issues{/number}",
"pulls_url": "https://api.github.com/repos/SpaceIm/conan-center-index/pulls{/number}",
"milestones_url": "https://api.github.com/repos/SpaceIm/conan-center-index/milestones{/number}",
"notifications_url": "https://api.github.com/repos/SpaceIm/conan-center-index/notifications{?since,all,participating}",
"labels_url": "https://api.github.com/repos/SpaceIm/conan-center-index/labels{/name}",
"releases_url": "https://api.github.com/repos/SpaceIm/conan-center-index/releases{/id}",
"deployments_url": "https://api.github.com/repos/SpaceIm/conan-center-index/deployments",
"created_at": "2019-12-20T12:43:32Z",
"updated_at": "2022-01-11T00:46:56Z",
"pushed_at": "2022-02-03T02:04:20Z",
"git_url": "git://github.com/SpaceIm/conan-center-index.git",
"ssh_url": "git@github.com:SpaceIm/conan-center-index.git",
"clone_url": "https://github.com/SpaceIm/conan-center-index.git",
"svn_url": "https://github.com/SpaceIm/conan-center-index",
"homepage": "https://bintray.com/conan/conan-center",
"size": 29130,
"stargazers_count": 0,
"watchers_count": 0,
"language": "Python",
"has_issues": false,
"has_projects": true,
"has_downloads": true,
"has_wiki": true,
"has_pages": false,
"forks_count": 0,
"mirror_url": null,
"archived": false,
"disabled": false,
"open_issues_count": 0,
"license": {
"key": "mit",
"name": "MIT License",
"spdx_id": "MIT",
"url": "https://api.github.com/licenses/mit",
"node_id": "MDc6TGljZW5zZTEz"
},
"allow_forking": true,
"is_template": false,
"topics": [
],
"visibility": "public",
"forks": 0,
"open_issues": 0,
"watchers": 0,
"default_branch": "master"
}
},
"base": {
"label": "conan-io:master",
"ref": "master",
"sha": "25a96ff635a2051d4d2c0f839db8b3f9c5643fc4",
"user": {
"login": "conan-io",
"id": 15212165,
"node_id": "MDEyOk9yZ2FuaXphdGlvbjE1MjEyMTY1",
"avatar_url": "https://avatars.githubusercontent.com/u/15212165?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/conan-io",
"html_url": "https://github.com/conan-io",
"followers_url": "https://api.github.com/users/conan-io/followers",
"following_url": "https://api.github.com/users/conan-io/following{/other_user}",
"gists_url": "https://api.github.com/users/conan-io/gists{/gist_id}",
"starred_url": "https://api.github.com/users/conan-io/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/conan-io/subscriptions",
"organizations_url": "https://api.github.com/users/conan-io/orgs",
"repos_url": "https://api.github.com/users/conan-io/repos",
"events_url": "https://api.github.com/users/conan-io/events{/privacy}",
"received_events_url": "https://api.github.com/users/conan-io/received_events",
"type": "Organization",
"site_admin": false
},
"repo": {
"id": 204671232,
"node_id": "MDEwOlJlcG9zaXRvcnkyMDQ2NzEyMzI=",
"name": "conan-center-index",
"full_name": "conan-io/conan-center-index",
"private": false,
"owner": {
"login": "conan-io",
"id": 15212165,
"node_id": "MDEyOk9yZ2FuaXphdGlvbjE1MjEyMTY1",
"avatar_url": "https://avatars.githubusercontent.com/u/15212165?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/conan-io",
"html_url": "https://github.com/conan-io",
"followers_url": "https://api.github.com/users/conan-io/followers",
"following_url": "https://api.github.com/users/conan-io/following{/other_user}",
"gists_url": "https://api.github.com/users/conan-io/gists{/gist_id}",
"starred_url": "https://api.github.com/users/conan-io/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/conan-io/subscriptions",
"organizations_url": "https://api.github.com/users/conan-io/orgs",
"repos_url": "https://api.github.com/users/conan-io/repos",
"events_url": "https://api.github.com/users/conan-io/events{/privacy}",
"received_events_url": "https://api.github.com/users/conan-io/received_events",
"type": "Organization",
"site_admin": false
},
"html_url": "https://github.com/conan-io/conan-center-index",
"description": "Recipes for the ConanCenter repository",
"fork": false,
"url": "https://api.github.com/repos/conan-io/conan-center-index",
"forks_url": "https://api.github.com/repos/conan-io/conan-center-index/forks",
"keys_url": "https://api.github.com/repos/conan-io/conan-center-index/keys{/key_id}",
"collaborators_url": "https://api.github.com/repos/conan-io/conan-center-index/collaborators{/collaborator}",
"teams_url": "https://api.github.com/repos/conan-io/conan-center-index/teams",
"hooks_url": "https://api.github.com/repos/conan-io/conan-center-index/hooks",
"issue_events_url": "https://api.github.com/repos/conan-io/conan-center-index/issues/events{/number}",
"events_url": "https://api.github.com/repos/conan-io/conan-center-index/events",
"assignees_url": "https://api.github.com/repos/conan-io/conan-center-index/assignees{/user}",
"branches_url": "https://api.github.com/repos/conan-io/conan-center-index/branches{/branch}",
"tags_url": "https://api.github.com/repos/conan-io/conan-center-index/tags",
"blobs_url": "https://api.github.com/repos/conan-io/conan-center-index/git/blobs{/sha}",
"git_tags_url": "https://api.github.com/repos/conan-io/conan-center-index/git/tags{/sha}",
"git_refs_url": "https://api.github.com/repos/conan-io/conan-center-index/git/refs{/sha}",
"trees_url": "https://api.github.com/repos/conan-io/conan-center-index/git/trees{/sha}",
"statuses_url": "https://api.github.com/repos/conan-io/conan-center-index/statuses/{sha}",
"languages_url": "https://api.github.com/repos/conan-io/conan-center-index/languages",
"stargazers_url": "https://api.github.com/repos/conan-io/conan-center-index/stargazers",
"contributors_url": "https://api.github.com/repos/conan-io/conan-center-index/contributors",
"subscribers_url": "https://api.github.com/repos/conan-io/conan-center-index/subscribers",
"subscription_url": "https://api.github.com/repos/conan-io/conan-center-index/subscription",
"commits_url": "https://api.github.com/repos/conan-io/conan-center-index/commits{/sha}",
"git_commits_url": "https://api.github.com/repos/conan-io/conan-center-index/git/commits{/sha}",
"comments_url": "https://api.github.com/repos/conan-io/conan-center-index/comments{/number}",
"issue_comment_url": "https://api.github.com/repos/conan-io/conan-center-index/issues/comments{/number}",
"contents_url": "https://api.github.com/repos/conan-io/conan-center-index/contents/{+path}",
"compare_url": "https://api.github.com/repos/conan-io/conan-center-index/compare/{base}...{head}",
"merges_url": "https://api.github.com/repos/conan-io/conan-center-index/merges",
"archive_url": "https://api.github.com/repos/conan-io/conan-center-index/{archive_format}{/ref}",
"downloads_url": "https://api.github.com/repos/conan-io/conan-center-index/downloads",
"issues_url": "https://api.github.com/repos/conan-io/conan-center-index/issues{/number}",
"pulls_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls{/number}",
"milestones_url": "https://api.github.com/repos/conan-io/conan-center-index/milestones{/number}",
"notifications_url": "https://api.github.com/repos/conan-io/conan-center-index/notifications{?since,all,participating}",
"labels_url": "https://api.github.com/repos/conan-io/conan-center-index/labels{/name}",
"releases_url": "https://api.github.com/repos/conan-io/conan-center-index/releases{/id}",
"deployments_url": "https://api.github.com/repos/conan-io/conan-center-index/deployments",
"created_at": "2019-08-27T09:43:58Z",
"updated_at": "2022-02-02T21:10:34Z",
"pushed_at": "2022-02-03T02:06:28Z",
"git_url": "git://github.com/conan-io/conan-center-index.git",
"ssh_url": "git@github.com:conan-io/conan-center-index.git",
"clone_url": "https://github.com/conan-io/conan-center-index.git",
"svn_url": "https://github.com/conan-io/conan-center-index",
"homepage": "https://conan.io/center",
"size": 28740,
"stargazers_count": 522,
"watchers_count": 522,
"language": "Python",
"has_issues": true,
"has_projects": true,
"has_downloads": true,
"has_wiki": true,
"has_pages": false,
"forks_count": 787,
"mirror_url": null,
"archived": false,
"disabled": false,
"open_issues_count": 944,
"license": {
"key": "mit",
"name": "MIT License",
"spdx_id": "MIT",
"url": "https://api.github.com/licenses/mit",
"node_id": "MDc6TGljZW5zZTEz"
},
"allow_forking": true,
"is_template": false,
"topics": [
"conan",
"conan-center",
"conan-index",
"conan-packages",
"conan-recipe",
"cpp",
"cpp-library",
"dependencies",
"hacktoberfest",
"package-management",
"package-manager"
],
"visibility": "public",
"forks": 787,
"open_issues": 944,
"watchers": 522,
"default_branch": "master"
}
},
"_links": {
"self": {
"href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/9169"
},
"html": {
"href": "https://github.com/conan-io/conan-center-index/pull/9169"
},
"issue": {
"href": "https://api.github.com/repos/conan-io/conan-center-index/issues/9169"
},
"comments": {
"href": "https://api.github.com/repos/conan-io/conan-center-index/issues/9169/comments"
},
"review_comments": {
"href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/9169/comments"
},
"review_comment": {
"href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/comments{/number}"
},
"commits": {
"href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/9169/commits"
},
"statuses": {
"href": "https://api.github.com/repos/conan-io/conan-center-index/statuses/2dbd36d7e6b0635872e5b5dc95cbd642e4d150af"
}
},
"author_association": "CONTRIBUTOR",
"auto_merge": null,
"active_lock_reason": null,
"merged": false,
"mergeable": true,
"rebaseable": true,
"mergeable_state": "clean",
"merged_by": null,
"comments": 2,
"review_comments": 1,
"maintainer_can_modify": true,
"commits": 1,
"additions": 278,
"deletions": 0,
"changed_files": 9
}https://api.github.com/repos/conan-io/conan-center-index/pulls/9169/reviews [
{
"id": 867159690,
"node_id": "PRR_kwDODDMJAM4zr86K",
"user": {
"login": "SpaceIm",
"id": 30052553,
"node_id": "MDQ6VXNlcjMwMDUyNTUz",
"avatar_url": "https://avatars.githubusercontent.com/u/30052553?u=b3eb54dd839ff56e1841edace5af866399c1ca15&v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/SpaceIm",
"html_url": "https://github.com/SpaceIm",
"followers_url": "https://api.github.com/users/SpaceIm/followers",
"following_url": "https://api.github.com/users/SpaceIm/following{/other_user}",
"gists_url": "https://api.github.com/users/SpaceIm/gists{/gist_id}",
"starred_url": "https://api.github.com/users/SpaceIm/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/SpaceIm/subscriptions",
"organizations_url": "https://api.github.com/users/SpaceIm/orgs",
"repos_url": "https://api.github.com/users/SpaceIm/repos",
"events_url": "https://api.github.com/users/SpaceIm/events{/privacy}",
"received_events_url": "https://api.github.com/users/SpaceIm/received_events",
"type": "User",
"site_admin": false
},
"body": "",
"state": "COMMENTED",
"html_url": "https://github.com/conan-io/conan-center-index/pull/9169#pullrequestreview-867159690",
"pull_request_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/9169",
"author_association": "CONTRIBUTOR",
"_links": {
"html": {
"href": "https://github.com/conan-io/conan-center-index/pull/9169#pullrequestreview-867159690"
},
"pull_request": {
"href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/9169"
}
},
"submitted_at": "2022-01-30T17:54:15Z",
"commit_id": "2dbd36d7e6b0635872e5b5dc95cbd642e4d150af"
}
]Hypothesis: conan-io/conan-center-index#9169 (comment) |
prince-chrismc
changed the title
|
conan-center-index-pending-review/pkg/pending_review/review.go Lines 37 to 40 in 06e04fc Needs to reverse the list of review and filter out all of the ones by the author... since they can not approve/block their own PR
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Something blocked a PR from being listed.
conan-io/conan-center-index#8379 (comment)
The text was updated successfully, but these errors were encountered: