add physfs/3.0.2 #9169
Merged
add physfs/3.0.2 #9169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpaceIm
commented
Jan 30, 2022
Comment on lines
+139
to
+140
| self.cpp_info.set_property("cmake_file_name", "PhysFS") | ||
| self.cpp_info.set_property("cmake_target_name", self._physfs_target) |
There was a problem hiding this comment.
FYI: there is no config file in 3.0.2, it's in master branch
|
All green in build 1 (
|
|
@prince-chrismc it seems that your bot missed this PR. |
|
There's a flaw in my logic. 🤯 If there are any reviews after the last commit, I assume there is work required by OP... I wanted to drop PRs from my board where the author did not apply the feedback but is seems to aagressive. |
intelligide
approved these changes
Feb 3, 2022
uilianries
approved these changes
Feb 4, 2022
prince-chrismc
approved these changes
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: lib/1.0
This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!
conan-center hook activated.