Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture any unhandled error during install command #126

Merged
merged 18 commits into from
Jul 16, 2019

Conversation

jgsogo
Copy link

@jgsogo jgsogo commented Jun 28, 2019

on top of #125

This is capturing the kind of error we get when the path to Conan is ill-formed. Related to #117 but doesn't close it as it is not checking the path at the moment the user modifies it.

@jgsogo jgsogo added this to the 1.2.0 milestone Jun 28, 2019
SSE4 added 2 commits July 8, 2019 04:35
Signed-off-by: SSE4 <tomskside@gmail.com>
Signed-off-by: SSE4 <tomskside@gmail.com>
@SSE4 SSE4 self-requested a review July 8, 2019 14:28
@jgsogo jgsogo force-pushed the issue/117-invalid-conan-executable branch from cf2dcb8 to a7ddc15 Compare July 16, 2019 11:49
@jgsogo jgsogo changed the title Capture any unhandled error related to the install command Capture any unhandled error during install command Jul 16, 2019
@jgsogo jgsogo marked this pull request as ready for review July 16, 2019 12:27
@SSE4
Copy link

SSE4 commented Jul 16, 2019

@jgsogo please rebase

@SSE4 SSE4 merged commit c40c75b into conan-io:dev Jul 16, 2019
@jgsogo jgsogo deleted the issue/117-invalid-conan-executable branch July 16, 2019 19:51
@jgsogo jgsogo mentioned this pull request Jul 23, 2019
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants