-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Capture any unhandled error during install command #126
Merged
SSE4
merged 18 commits into
conan-io:dev
from
jgsogo:issue/117-invalid-conan-executable
Jul 16, 2019
Merged
Capture any unhandled error during install command #126
SSE4
merged 18 commits into
conan-io:dev
from
jgsogo:issue/117-invalid-conan-executable
Jul 16, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SSE4 <tomskside@gmail.com>
Signed-off-by: SSE4 <tomskside@gmail.com>
jgsogo
force-pushed
the
issue/117-invalid-conan-executable
branch
from
July 16, 2019 11:49
cf2dcb8
to
a7ddc15
Compare
Signed-off-by: SSE4 <tomskside@gmail.com>
jgsogo
changed the title
Capture any unhandled error related to the install command
Capture any unhandled error during install command
Jul 16, 2019
Signed-off-by: SSE4 <tomskside@gmail.com>
…nto validate_conan
Co-Authored-By: Javier G. Sogo <jgsogo@gmail.com>
Validate path to Conan executable
@jgsogo please rebase |
SSE4
approved these changes
Jul 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on top of #125
This is capturing the kind of error we get when the path to Conan is ill-formed. Related to #117 but doesn't close it as it is not checking the path at the moment the user modifies it.