-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/premakedeps #13350
Feature/premakedeps #13350
Conversation
- Fixed bugs that only occur in "fresh" deployments - Fixed bugs that only occur in edge cases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks quite good, clean, with templates, new test, etc, good job.
If we want to move this forward for the next patches releases 2.0.X, this PR should be targeted to the release/2.0
branch. As long as we don't document it, it should be very doable.
At some point we might want to add some functional test that really builds something simple, but that can wait a bit if you are running functional testing on your side.
pkg_files = [] | ||
dep_names = [] | ||
for require, dep in list(host_req.items()) + list(test_req.items()) + list(build_req.items()): | ||
dep_name = require.ref.name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This for
internals is a bit too long, might benefit from some splitting.
f"{self.tab * indent}{line}" for line in list(filter(None, string.splitlines())) | ||
]) | ||
|
||
def _premake_filtered(self, content, configuration, architecture, indent=0): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These filters are quite unknown for others (like us) not knowing Premake. A short explanation or a link to somewhere that defines what are those would be nice.
@memsharded Thank you for your first feedback. I will close this PR then and open a new one based on the correct branch and targeted towards |
Summary
Changelog: Feature / Bugfix: Adding support for premake5 (PremakeDeps) fixes #13275
Docs: https://github.com/conan-io/docs/pull/XXXX
Features
conandeps.premake5.lua
file with functions (see previous) for automatic premake project setup.release
when no fitting conan configuration is availableStatus
WIP-Status: Code works and has been covered with a basic unit test. Documentation is still required.
Checklist
develop
branch, documenting this one.Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.