-
Notifications
You must be signed in to change notification settings - Fork 988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/premakedeps #13390
Feature/premakedeps #13390
Conversation
- Fixed bugs that only occur in "fresh" deployments - Fixed bugs that only occur in edge cases
@memsharded In #13350 you have mentioned "As long as we don't document it, it should be very doable". So, shall I wait with writing the documentation until I implement the full premake toolchain? So that you can merge this PR and get the |
Yes, exactly, it is possible to merge it to allow easier preliminary testing for early adopters, contributors and maintainers, without being too constrained to change things. I'd wait until we have the basic pieces working together and a bit of our own testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments and doubts, please have a look.
Then, would you say this is ready to move forward, merge (quietly, no docs yet) it, and keep working on the other pieces?
Added feedback for appending and referencing by explicit filename. Co-authored-by: James <memsharded@gmail.com>
Yes, as soon as we have discussed the two open points this should be ready for a silent merge. |
- Uncommon feature: "_premake_filtered_fallback" - Better consumption with a function in style of "conan_setup(conf, pkg)" By: - Change lua variable to be stored in a table - Changed consumption of lua variables
@memsharded can you please give me an update |
Sorry, I have been buried by a lot of other things. Just assigned this for next 2.0.4 so we can prioritize it. |
Merged! It will be in next 2.0.4 |
Changelog: Feature: Adding preliminary (non documented, dev-only) support for premake5 deps (PremakeDeps).
Docs: Omit
Fixes #13275 (Based on PR #13350)
Features
conandeps.premake5.lua
file with functions (see previous) for automatic premake project setup.release
when no fitting conan configuration is availableStatus
WIP-Status: Code works and has been covered with a basic unit test. Documentation is still required.
Checklist
I've opened another PR in the Conan docs repo to theDelayed until full premake5 support is implemented.develop
branch, documenting this one.Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.