[BazelDeps] glob() compatible with bazel 8.x
#17444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czoido
reviewed
Dec 11, 2024
Comment on lines
+23
to
+25
| BAZEL_6_5_0=6.5.0 \ | ||
| BAZEL_7_4_1=7.4.1 \ | ||
| BAZEL_8_0_0=8.0.0 |
There was a problem hiding this comment.
Minor suggestion, name this with the major so we just need to change this part for future updates:
Suggested change
| BAZEL_6_5_0=6.5.0 \ | |
| BAZEL_7_4_1=7.4.1 \ | |
| BAZEL_8_0_0=8.0.0 | |
| BAZEL_6=6.5.0 \ | |
| BAZEL_7=7.4.1 \ | |
| BAZEL_8=8.0.0 |
czoido
reviewed
Dec 11, 2024
Comment on lines
+149
to
+158
| "default": "7", | ||
| "6.5.0": {"path": {'Linux': '/usr/share/bazel-6.5.0/bin', | ||
| 'Windows': 'C:/tools/bazel/6.5.0', | ||
| 'Darwin': '/Users/runner/Applications/bazel/6.5.0'}}, | ||
| "7.4.1": {"path": {'Linux': '/usr/share/bazel-7.4.1/bin', | ||
| 'Windows': 'C:/tools/bazel/7.4.1', | ||
| 'Darwin': '/Users/runner/Applications/bazel/7.4.1'}}, | ||
| "8.0.0": {"path": {'Linux': '/usr/share/bazel-8.0.0/bin', | ||
| 'Windows': 'C:/tools/bazel/8.0.0', | ||
| 'Darwin': '/Users/runner/Applications/bazel/8.0.0'}}, |
There was a problem hiding this comment.
If we put just the major we don't have to update the tests marks in case we change versions
Suggested change
| "default": "7", | |
| "6.5.0": {"path": {'Linux': '/usr/share/bazel-6.5.0/bin', | |
| 'Windows': 'C:/tools/bazel/6.5.0', | |
| 'Darwin': '/Users/runner/Applications/bazel/6.5.0'}}, | |
| "7.4.1": {"path": {'Linux': '/usr/share/bazel-7.4.1/bin', | |
| 'Windows': 'C:/tools/bazel/7.4.1', | |
| 'Darwin': '/Users/runner/Applications/bazel/7.4.1'}}, | |
| "8.0.0": {"path": {'Linux': '/usr/share/bazel-8.0.0/bin', | |
| 'Windows': 'C:/tools/bazel/8.0.0', | |
| 'Darwin': '/Users/runner/Applications/bazel/8.0.0'}}, | |
| "default": "7", | |
| "6": {"path": {'Linux': '/usr/share/bazel-6.5.0/bin', | |
| 'Windows': 'C:/tools/bazel/6.5.0', | |
| 'Darwin': '/Users/runner/Applications/bazel/6.5.0'}}, | |
| "7": {"path": {'Linux': '/usr/share/bazel-7.4.1/bin', | |
| 'Windows': 'C:/tools/bazel/7.4.1', | |
| 'Darwin': '/Users/runner/Applications/bazel/7.4.1'}}, | |
| "8": {"path": {'Linux': '/usr/share/bazel-8.0.0/bin', | |
| 'Windows': 'C:/tools/bazel/8.0.0', | |
| 'Darwin': '/Users/runner/Applications/bazel/8.0.0'}}, |
czoido
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Added explicitly
allow_empty = Truetoglob()function in BazelDeps (bazel 8.x compatible).Docs: omit
Closes: #17438
Note: Updated the installed versions of Bazel to the latest ones too.