Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CircleCI support (#2359) #2808

Merged
merged 2 commits into from
Apr 27, 2018

Conversation

uilianries
Copy link
Member

@uilianries uilianries commented Apr 26, 2018

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one. Also adding a description of the changes in the changelog.rst file. https://github.com/conan-io/docs

Hi!

This PR solves the issue #2359

I added the template to fill Linux and Mac support. However, I think Mac will be rarely used, because it's paid.

The PR with docs update is here: conan-io/docs#636

Regards!

- Create Conan + CircleCI project template using command new
- Create Conan + CircleCI project template using API

Signed-off-by: Uilian Ries <uilianries@gmail.com>
- Test CircleCI template

Signed-off-by: Uilian Ries <uilianries@gmail.com>
@ghost ghost added the contributor pr label Apr 26, 2018
@memsharded
Copy link
Member

This looks very good. I vote for merging it and release in 1.3, doc it as "experimental" to be able to iterate next versions if necessary.

@memsharded memsharded added this to the 1.3 milestone Apr 26, 2018
@memsharded memsharded merged commit 10aedbc into conan-io:develop Apr 27, 2018
@ghost ghost removed the contributor pr label Apr 27, 2018
@memsharded
Copy link
Member

Merged! Will be in 1.3

grisumbras pushed a commit to grisumbras/conan that referenced this pull request Dec 27, 2018
* conan-io#2359 Add Circle CI support

- Create Conan + CircleCI project template using command new
- Create Conan + CircleCI project template using API

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* conan-io#2359 Validate CircleCI support

- Test CircleCI template

Signed-off-by: Uilian Ries <uilianries@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants