Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2359 Add CircleCI support #636

Merged
merged 1 commit into from
Apr 27, 2018
Merged

Conversation

uilianries
Copy link
Member

Related issue: conan-io/conan#2359

  • Add circleci integration page
  • Update command conan new

@ghost ghost added the contributor pr label Apr 26, 2018
@danimtb danimtb self-assigned this Apr 26, 2018
@danimtb danimtb added this to the 1.3 milestone Apr 26, 2018
@danimtb
Copy link
Member

danimtb commented Apr 26, 2018

Hi @uilianries!

Thanks a lot for the CircleCI integration. Docs look good to me! 💯

I see some new files in this PR related to bintray and conan new command out of place:

  • packaging/bintray/conan_center_guide.rst
  • reference/commands/new.rst

Those files were moved long time ago.

Maybe you branch was outdated? Please have a look to it

Thanks again! 😄

@uilianries
Copy link
Member Author

yeah, could be. Thanks to report, I'll fix soon.

- Add circleci integration page
- Update command conan new

Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries
Copy link
Member Author

Done!

I forgot to rebase before to start the feature. 🤦‍♂️
When I finished the feature, I tried to rebase, but some conflicts were generated.

Regards!

@memsharded memsharded merged commit 02d9b5b into conan-io:develop Apr 27, 2018
@ghost ghost removed the in review label Apr 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants