Wrap imported CSS in an at scope rule #4613
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
User CSS can affect the editor itself. This was fixed by #4604 (and the follow up patch #4611), but that approach is prone to edge cases.
Fix:
As we are primarily targeting Chrome, we can surround user's CSS in
@scope (#canvas-container){ ... }
at the point of importing in order to scope it to only within the canvas container itself. There are a small number of selectors (e.g.body
and:root
) that have to be replaced with the:scope
selector, but otherwise we can leave the remaining imported CSS untouched.I've had to update the version of puppeteer used so that we are now running the tests on a version of Chrome that supports this rule (as previously this was breaking the performance tests)
Notes:
@scope
is landing in Safari@scope
CSS @scope mozilla/standards-positions#472