Skip CSS re-scoping in package-manager.spec #4754
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
We introduced
@scope
scoping into imported CSS in #4613, but this is causing issues with jsdom when runningpackage-manager.spec
, often causing aHeap Out Of Memory
error when running on CI, leading to the jest job timing out.Fix:
Since we aren't even testing the
@scope
scoping in the affected tests, I've used a mock to skip it. We have other tests incss-utils.spec
for ensuring the scoping is working correctly.