Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip CSS re-scoping in package-manager.spec #4754

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

Rheeseyb
Copy link
Contributor

Problem:
We introduced @scope scoping into imported CSS in #4613, but this is causing issues with jsdom when running package-manager.spec, often causing a Heap Out Of Memory error when running on CI, leading to the jest job timing out.

Fix:
Since we aren't even testing the @scope scoping in the affected tests, I've used a mock to skip it. We have other tests in css-utils.spec for ensuring the scoping is working correctly.

Copy link
Contributor

github-actions bot commented Jan 16, 2024

Try me

Copy link

relativeci bot commented Jan 16, 2024

Job #9938: Bundle Size — 62.22MiB (~-0.01%).

0703b38(current) vs 8f5e3ac master#9937(baseline)

Warning

Bundle contains 66 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Improvement 1 improvement
                 Current
Job #9938
     Baseline
Job #9937
Improvement  Initial JS 45.41MiB(~-0.01%) 45.41MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 19.85% 21.67%
No change  Chunks 26 26
No change  Assets 30 30
No change  Modules 4368 4368
No change  Duplicate Modules 471 471
No change  Duplicate Code 30.72% 30.72%
No change  Packages 462 462
No change  Duplicate Packages 65 65
Bundle size by type  Change 1 change Improvement 1 improvement
                 Current
Job #9938
     Baseline
Job #9937
Improvement  JS 62.21MiB (~-0.01%) 62.21MiB
Not changed  HTML 11.54KiB 11.54KiB

View job #9938 reportView fix/package-manager-css-tests branch activityView project dashboard

Copy link
Contributor

Performance test results:
(Chart1)
(Chart2)

@Rheeseyb Rheeseyb merged commit d4a42d5 into master Jan 16, 2024
13 of 14 checks passed
@Rheeseyb Rheeseyb deleted the fix/package-manager-css-tests branch January 16, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants