Updates ktlint and removes the html reporter jar dependency #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sorry the commit was made using a different author, i'll update the local project props so it doesn't happen again |
rodrigo-mnz
reviewed
Mar 27, 2018
| @@ -8,6 +8,5 @@ task ktlint(type: JavaExec, group: "verification") { | |||
| main = "com.github.shyiko.ktlint.Main" | |||
| args "src/**/*.kt" | |||
| args "--android=true" | |||
| args "--ruleset=${rootDir}/tools/html-reporter.jar" | |||
| args "--reporter=html,output=${buildDir}/ktlint.html" | |||
| args "--reporter=html,artifact=com.github.mcassiano:ktlint-html-reporter:0.0.1,output=${buildDir}/ktlint.html" | |||
There was a problem hiding this comment.
It's this "com.github.mcassiano:ktlint-html-reporter:0.0.1" correct? Shouldn't be from the main repo?
There was a problem hiding this comment.
It’s correct, see https://github.com/mcassiano/ktlint-html-reporter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ktlint fixed a bug that was preventing external reporters to be loaded, so by bumping its version I can also delete the jar dependency. see #176