Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates ktlint and removes the html reporter jar dependency #8

Merged
merged 1 commit into from
Mar 28, 2018
Merged

Updates ktlint and removes the html reporter jar dependency #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ ext {
roboeletricVersion = "3.6.1"
canarinhoVersion = "1.2.0"
lottieVersion = "2.5.0-rc1"
ktlintVersion = "0.19.0"
ktlintVersion = "0.20.0"
detektVersion = "1.0.0.RC6-3"
}

Expand Down
Binary file removed tools/html-reporter.jar
View file
Open in desktop
Binary file not shown.
3 changes: 1 addition & 2 deletions tools/quality.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,5 @@ task ktlint(type: JavaExec, group: "verification") {
main = "com.github.shyiko.ktlint.Main"
args "src/**/*.kt"
args "--android=true"
args "--ruleset=${rootDir}/tools/html-reporter.jar"
args "--reporter=html,output=${buildDir}/ktlint.html"
args "--reporter=html,artifact=com.github.mcassiano:ktlint-html-reporter:0.0.1,output=${buildDir}/ktlint.html"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's this "com.github.mcassiano:ktlint-html-reporter:0.0.1" correct? Shouldn't be from the main repo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s correct, see https://github.com/mcassiano/ktlint-html-reporter

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, LGTM

}