Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.3.0rc0 #150

Merged
merged 4 commits into from
Jan 25, 2024
Merged

4.3.0rc0 #150

merged 4 commits into from
Jan 25, 2024

Conversation

phoebusm
Copy link
Contributor

@phoebusm phoebusm commented Jan 24, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@phoebusm
Copy link
Contributor Author

@conda-forge-admin, please rerender

Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/arcticdb-feedstock/actions/runs/7644681182.

@jjerphan
Copy link
Member

@conda-forge-admin, please rerender

Copy link
Member

@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo a 🟢 CI.

…torage

Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@jjerphan jjerphan added the automerge Merge the PR when CI passes label Jan 25, 2024
@github-actions github-actions bot merged commit cc4d7e2 into conda-forge:rc Jan 25, 2024
22 checks passed
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@@ -90,7 +91,6 @@ requirements:
# To keep in sync with `install_requires` in setup.cfg.
- numpy
- pandas
- attrs
Copy link
Member

@jjerphan jjerphan Jan 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually required in practice.

Traceback of 4.3.0rc0 py39hab09b7a_0
In [1]: import arcticdb
---------------------------------------------------------------------------
ModuleNotFoundError                       Traceback (most recent call last)
Cell In[1], line 1
----> 1 import arcticdb

File ~/.local/share/miniforge3/envs/test/lib/python3.9/site-packages/arcticdb/__init__.py:5
      2 import os as _os
      3 import sys as _sys
----> 5 from arcticdb.arctic import Arctic
      6 from arcticdb.options import LibraryOptions
      7 from arcticdb.version_store.processing import QueryBuilder

File ~/.local/share/miniforge3/envs/test/lib/python3.9/site-packages/arcticdb/arctic.py:14
     12 from arcticdb_ext.storage import LibraryManager
     13 from arcticdb.exceptions import LibraryNotFound, MismatchingLibraryOptions
---> 14 from arcticdb.version_store.library import ArcticInvalidApiUsageException, Library
     15 from arcticdb.version_store._store import NativeVersionStore
     16 from arcticdb.adapters.arctic_library_adapter import ArcticLibraryAdapter

File ~/.local/share/miniforge3/envs/test/lib/python3.9/site-packages/arcticdb/version_store/__init__.py:2
      1 from arcticdb.version_store._common import TimeFrame
----> 2 from arcticdb.version_store._store import NativeVersionStore, VersionedItem

File ~/.local/share/miniforge3/envs/test/lib/python3.9/site-packages/arcticdb/version_store/_store.py:15
     13 import re
     14 import itertools
---> 15 import attr
     16 import warnings
     17 import difflib

ModuleNotFoundError: No module named 'attr'

The test suite does not fail because packages from the test environment pull attrs in.

Copy link
Member

@jjerphan jjerphan Jan 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#154 was opened to reintroduce it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

man-group/ArcticDB#1272 was opened upstream as well.

@jjerphan jjerphan mentioned this pull request Jan 26, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants