-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4.3.0rc0 #150
4.3.0rc0 #150
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/arcticdb-feedstock/actions/runs/7644681182. |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.01.24.18.23.23
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo a 🟢 CI.
…torage Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
@@ -90,7 +91,6 @@ requirements: | |||
# To keep in sync with `install_requires` in setup.cfg. | |||
- numpy | |||
- pandas | |||
- attrs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually required in practice.
Traceback of 4.3.0rc0 py39hab09b7a_0
In [1]: import arcticdb
---------------------------------------------------------------------------
ModuleNotFoundError Traceback (most recent call last)
Cell In[1], line 1
----> 1 import arcticdb
File ~/.local/share/miniforge3/envs/test/lib/python3.9/site-packages/arcticdb/__init__.py:5
2 import os as _os
3 import sys as _sys
----> 5 from arcticdb.arctic import Arctic
6 from arcticdb.options import LibraryOptions
7 from arcticdb.version_store.processing import QueryBuilder
File ~/.local/share/miniforge3/envs/test/lib/python3.9/site-packages/arcticdb/arctic.py:14
12 from arcticdb_ext.storage import LibraryManager
13 from arcticdb.exceptions import LibraryNotFound, MismatchingLibraryOptions
---> 14 from arcticdb.version_store.library import ArcticInvalidApiUsageException, Library
15 from arcticdb.version_store._store import NativeVersionStore
16 from arcticdb.adapters.arctic_library_adapter import ArcticLibraryAdapter
File ~/.local/share/miniforge3/envs/test/lib/python3.9/site-packages/arcticdb/version_store/__init__.py:2
1 from arcticdb.version_store._common import TimeFrame
----> 2 from arcticdb.version_store._store import NativeVersionStore, VersionedItem
File ~/.local/share/miniforge3/envs/test/lib/python3.9/site-packages/arcticdb/version_store/_store.py:15
13 import re
14 import itertools
---> 15 import attr
16 import warnings
17 import difflib
ModuleNotFoundError: No module named 'attr'
The test suite does not fail because packages from the test environment pull attrs
in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#154 was opened to reintroduce it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
man-group/ArcticDB#1272 was opened upstream as well.
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)