Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.3.0rc0 #150

Merged
merged 4 commits into from
Jan 25, 2024
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ spdlog:
- '1.11'
target_platform:
- linux-64
xxhash:
- 0.8.2
zip_keys:
- - c_compiler_version
- cxx_compiler_version
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ spdlog:
- '1.11'
target_platform:
- linux-64
xxhash:
- 0.8.2
zip_keys:
- - c_compiler_version
- cxx_compiler_version
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ spdlog:
- '1.11'
target_platform:
- linux-64
xxhash:
- 0.8.2
zip_keys:
- - c_compiler_version
- cxx_compiler_version
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ spdlog:
- '1.11'
target_platform:
- linux-64
xxhash:
- 0.8.2
zip_keys:
- - c_compiler_version
- cxx_compiler_version
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ spdlog:
- '1.11'
target_platform:
- linux-64
xxhash:
- 0.8.2
zip_keys:
- - c_compiler_version
- cxx_compiler_version
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ spdlog:
- '1.11'
target_platform:
- linux-64
xxhash:
- 0.8.2
zip_keys:
- - c_compiler_version
- cxx_compiler_version
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ spdlog:
- '1.11'
target_platform:
- linux-64
xxhash:
- 0.8.2
zip_keys:
- - c_compiler_version
- cxx_compiler_version
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ spdlog:
- '1.11'
target_platform:
- linux-64
xxhash:
- 0.8.2
zip_keys:
- - c_compiler_version
- cxx_compiler_version
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@ spdlog:
- '1.11'
target_platform:
- osx-64
xxhash:
- 0.8.2
zip_keys:
- - c_compiler_version
- cxx_compiler_version
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@ spdlog:
- '1.11'
target_platform:
- osx-64
xxhash:
- 0.8.2
zip_keys:
- - c_compiler_version
- cxx_compiler_version
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@ spdlog:
- '1.11'
target_platform:
- osx-64
xxhash:
- 0.8.2
zip_keys:
- - c_compiler_version
- cxx_compiler_version
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@ spdlog:
- '1.11'
target_platform:
- osx-64
xxhash:
- 0.8.2
zip_keys:
- - c_compiler_version
- cxx_compiler_version
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@ spdlog:
- '1.11'
target_platform:
- osx-64
xxhash:
- 0.8.2
zip_keys:
- - c_compiler_version
- cxx_compiler_version
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@ spdlog:
- '1.11'
target_platform:
- osx-64
xxhash:
- 0.8.2
zip_keys:
- - c_compiler_version
- cxx_compiler_version
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ spdlog:
- '1.11'
target_platform:
- osx-arm64
xxhash:
- 0.8.2
zip_keys:
- - c_compiler_version
- cxx_compiler_version
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ spdlog:
- '1.11'
target_platform:
- osx-arm64
xxhash:
- 0.8.2
zip_keys:
- - c_compiler_version
- cxx_compiler_version
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ spdlog:
- '1.11'
target_platform:
- osx-arm64
xxhash:
- 0.8.2
zip_keys:
- - c_compiler_version
- cxx_compiler_version
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ spdlog:
- '1.11'
target_platform:
- osx-arm64
xxhash:
- 0.8.2
zip_keys:
- - c_compiler_version
- cxx_compiler_version
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ spdlog:
- '1.11'
target_platform:
- osx-arm64
xxhash:
- 0.8.2
zip_keys:
- - c_compiler_version
- cxx_compiler_version
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ spdlog:
- '1.11'
target_platform:
- osx-arm64
xxhash:
- 0.8.2
zip_keys:
- - c_compiler_version
- cxx_compiler_version
Expand Down
2 changes: 2 additions & 0 deletions recipe/conda_build_config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ folly:
- "2023.09.25.00"
nodejs:
- "18"
xxhash:
- 0.8.2

# Coupling dependencies specification together.
# The first lines come from the specifications of the `libevent-2.1.10` branch.
Expand Down
9 changes: 5 additions & 4 deletions recipe/meta.yaml
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
{% set name = "arcticdb" %}
{% set version = "4.2.0rc0" %}
{% set version = "4.3.0rc0" %}

package:
name: {{ name|lower }}
version: {{ version }}

source:
url: https://github.com/man-group/ArcticDB/archive/refs/tags/v{{ version }}.tar.gz
sha256: 365bed911941a5d0a832833a2296a54c87472508cc132beeb546b0d53294d8f7
sha256: b4df8749f36e0fed7d3f53f660f0ff4d43b72593067e43aedf94fcccb8778847
patches:
- patches/0001-Skip-pyarrow.patch

Expand All @@ -19,7 +19,7 @@ build:
# Fixing requires to rebuild the whole stack while OSX build
# for python 3.8 is not used by anyone.
skip: true # [osx and py<39]
number: 3
number: 0

entry_points:
- arcticdb_update_storage = arcticdb.scripts.update_storage:main
Expand Down Expand Up @@ -81,6 +81,7 @@ requirements:
- fmt <10
- glog
- gtest
- benchmark
run:
# This environment specification must be maintained in sync with the one upstream:
# See: https://github.com/man-group/ArcticDB/blob/master/environment_unix.yml
Expand All @@ -90,7 +91,6 @@ requirements:
# To keep in sync with `install_requires` in setup.cfg.
- numpy
- pandas
- attrs
Copy link
Member

@jjerphan jjerphan Jan 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually required in practice.

Traceback of 4.3.0rc0 py39hab09b7a_0
In [1]: import arcticdb
---------------------------------------------------------------------------
ModuleNotFoundError                       Traceback (most recent call last)
Cell In[1], line 1
----> 1 import arcticdb

File ~/.local/share/miniforge3/envs/test/lib/python3.9/site-packages/arcticdb/__init__.py:5
      2 import os as _os
      3 import sys as _sys
----> 5 from arcticdb.arctic import Arctic
      6 from arcticdb.options import LibraryOptions
      7 from arcticdb.version_store.processing import QueryBuilder

File ~/.local/share/miniforge3/envs/test/lib/python3.9/site-packages/arcticdb/arctic.py:14
     12 from arcticdb_ext.storage import LibraryManager
     13 from arcticdb.exceptions import LibraryNotFound, MismatchingLibraryOptions
---> 14 from arcticdb.version_store.library import ArcticInvalidApiUsageException, Library
     15 from arcticdb.version_store._store import NativeVersionStore
     16 from arcticdb.adapters.arctic_library_adapter import ArcticLibraryAdapter

File ~/.local/share/miniforge3/envs/test/lib/python3.9/site-packages/arcticdb/version_store/__init__.py:2
      1 from arcticdb.version_store._common import TimeFrame
----> 2 from arcticdb.version_store._store import NativeVersionStore, VersionedItem

File ~/.local/share/miniforge3/envs/test/lib/python3.9/site-packages/arcticdb/version_store/_store.py:15
     13 import re
     14 import itertools
---> 15 import attr
     16 import warnings
     17 import difflib

ModuleNotFoundError: No module named 'attr'

The test suite does not fail because packages from the test environment pull attrs in.

Copy link
Member

@jjerphan jjerphan Jan 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#154 was opened to reintroduce it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

man-group/ArcticDB#1272 was opened upstream as well.

- decorator
- msgpack-python
- psutil
Expand Down Expand Up @@ -127,6 +127,7 @@ test:
- asv
- virtualenv
- pymongo
- mock
# Extra dependencies
- pytest-rerunfailures
- nodejs # for npm
Expand Down
Loading