-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Be explicit about ARROW_ACERO; add tests; remove use_local
in migrators
#1037
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/arrow-cpp-feedstock/actions/runs/4860351773. |
Interestingly, this got picked up on main already, on all platforms (I checked that we're not missing options that should be on before merging #1034):
The new Something like the below --- a/recipe/meta.yaml
+++ b/recipe/meta.yaml
@@ -139,8 +139,8 @@ outputs:
test:
commands:
{% set headers = [
- "arrow/api.h", "arrow/flight/types.h", "arrow/flight/sql/api.h",
- "gandiva/engine.h", "parquet/api/reader.h"
+ "arrow/api.h", "arrow/acero/groupby.h", "arrow/flight/types.h",
+ "arrow/flight/sql/api.h", "gandiva/engine.h", "parquet/api/reader.h"
] %}
{% for each_header in headers %}
# headers
@@ -149,8 +149,8 @@ outputs:
{% endfor %}
{% set libs = (cuda_compiler_version != "None") * ["arrow_cuda"] + [
- "arrow", "arrow_dataset", "arrow_flight", "arrow_flight_sql",
- "arrow_substrait", "gandiva", "parquet"
+ "arrow", "arrow_acero", "arrow_dataset", "arrow_flight",
+ "arrow_flight_sql", "arrow_substrait", "gandiva", "parquet"
] %}
{% for each_lib in libs %}
# shared |
I believe ARROW_DATASET enables ACERO, so that must be why it's already on. Good to be explicit though. |
Thanks, it seems that as
and
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming green CI of course.
Thanks for the PR! :)
…nda-forge-pinning 2023.05.02.20.47.11
I piggy-backed a small change into this PR to fix #1039, so we don't need another separate build for that. |
use_local
in migrators
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)Based on the Post-release mailing list for ARROW 12.0.0:
https://lists.apache.org/thread/2stklo8dgpgn4dkq2lmvy4483jqcxzgx
Arrow Acero has been split into libarrow_acero for 12.0.0. We should enable it on conda.
See original arrow issue:
Closes #1039