Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be explicit about ARROW_ACERO; add tests; remove use_local in migrators #1037

Merged
merged 4 commits into from
May 3, 2023
Merged

Be explicit about ARROW_ACERO; add tests; remove use_local in migrators #1037

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d1e3e44
Enable ARROW_ACERO
raulcd May 2, 2023
2f7534b
Revert build number + add tests as suggested
raulcd May 2, 2023
52bc8f4
remove obsolete migrations with `use_local: true`
h-vetinari May 2, 2023
e0bf845
MNT: Re-rendered with conda-build 3.24.0, conda-smithy 3.23.1, and co…
h-vetinari May 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion recipe/bld-arrow.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,9 @@ if "%cuda_compiler_version%"=="None" (
set "READ_RECIPE_META_YAML_WHY_NOT=OFF"

:: for available switches see
:: https://github.com/apache/arrow/blame/apache-arrow-11.0.0/cpp/cmake_modules/DefineOptions.cmake
:: https://github.com/apache/arrow/blame/apache-arrow-12.0.0/cpp/cmake_modules/DefineOptions.cmake
cmake -G "Ninja" ^
-DARROW_ACERO=ON ^
-DARROW_BOOST_USE_SHARED:BOOL=ON ^
-DARROW_BUILD_STATIC:BOOL=OFF ^
-DARROW_BUILD_TESTS:BOOL=OFF ^
Expand Down
3 changes: 2 additions & 1 deletion recipe/build-arrow.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,10 @@ fi
export READ_RECIPE_META_YAML_WHY_NOT=OFF

# for available switches see
# https://github.com/apache/arrow/blame/apache-arrow-11.0.0/cpp/cmake_modules/DefineOptions.cmake
# https://github.com/apache/arrow/blame/apache-arrow-12.0.0/cpp/cmake_modules/DefineOptions.cmake
# placeholder in ARROW_GDB_INSTALL_DIR must match what's used for replacement in activate.sh
cmake -GNinja \
-DARROW_ACERO=ON \
-DARROW_BOOST_USE_SHARED=ON \
-DARROW_BUILD_BENCHMARKS=OFF \
-DARROW_BUILD_STATIC=OFF \
Expand Down
8 changes: 4 additions & 4 deletions recipe/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,8 @@ outputs:
test:
commands:
{% set headers = [
"arrow/api.h", "arrow/flight/types.h", "arrow/flight/sql/api.h",
"gandiva/engine.h", "parquet/api/reader.h"
"arrow/api.h", "arrow/acero/groupby.h", "arrow/flight/types.h",
"arrow/flight/sql/api.h", "gandiva/engine.h", "parquet/api/reader.h"
] %}
{% for each_header in headers %}
# headers
Expand All @@ -149,8 +149,8 @@ outputs:
{% endfor %}

{% set libs = (cuda_compiler_version != "None") * ["arrow_cuda"] + [
"arrow", "arrow_dataset", "arrow_flight", "arrow_flight_sql",
"arrow_substrait", "gandiva", "parquet"
"arrow", "arrow_acero", "arrow_dataset", "arrow_flight",
"arrow_flight_sql", "arrow_substrait", "gandiva", "parquet"
] %}
{% for each_lib in libs %}
# shared
Expand Down