Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UCC to global pinning #6484

Merged
merged 4 commits into from
Sep 29, 2024
Merged

Add UCC to global pinning #6484

merged 4 commits into from
Sep 29, 2024

Conversation

leofang
Copy link
Member

@leofang leofang commented Sep 29, 2024

cc @conda-forge/ucc @conda-forge/openmpi

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@leofang leofang requested a review from a team as a code owner September 29, 2024 18:58
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@hmaarrfk
Copy link
Contributor

Your run export is for the major version only.

can we just add a pin of "1" to the global pinning?

    - {{ pin_subpackage("ucc") }}

https://github.com/conda-forge/ucc-feedstock/blob/main/recipe/meta.yaml

@leofang
Copy link
Member Author

leofang commented Sep 29, 2024

good catch, done

@hmaarrfk
Copy link
Contributor

The earliest version of the package was 1.2.

so any 1.2 build should be compatibile even with 1.X.

so you can just directly add it to https://github.com/conda-forge/conda-forge-pinning-feedstock/blob/main/recipe/conda_build_config.yaml#L888

ucc:
   - 1

@leofang
Copy link
Member Author

leofang commented Sep 29, 2024

Sure, if touching conda_build_config.yaml directly is better. Done.

@hmaarrfk
Copy link
Contributor

Sure, if touching conda_build_config.yaml directly is better. Done.

In these cases where you are being proactive, its just simpler and avoids rebuilds!

@hmaarrfk hmaarrfk merged commit 69ea340 into conda-forge:main Sep 29, 2024
3 checks passed
@leofang leofang deleted the ucc branch September 29, 2024 19:44
@leofang
Copy link
Member Author

leofang commented Sep 29, 2024

Thanks, Mark!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants