Add UCC support

[j34ni]

Summary

• Added support for UCC (build_with_ucc="--with-ucc=$PREFIX")
• Added addition ompi_info based tests

Checklist

• Used a personal fork of the feedstock to propose changes
• Bumped the build number (if the version is unchanged)
• Reset the build number to 0 (if the version changed)
• Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
• Ensured the license file is being packaged.

[conda-forge-webservices]

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

• Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [66, 84]

[github-actions]

Hi! This is the friendly automated conda-forge-linting service.

I Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint --conda-forge . from the recipe directory.

[conda-forge-webservices]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

[minrk]

Thanks for working on this!

[leofang]

@conda-forge-admin, please rerender

[github-actions]

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the latest webservices GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or you can try rerendering locally.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/openmpi-feedstock/actions/runs/11061278004.

[minrk]

The main reason ucx was excluded as a hard dependency was to save space because it resulted in hundreds of megabytes of extra packages due to cuda stuff. That's not true anymore since #119, so would it simplify things to make ucc/ucx a plain conda dependency? I don't entirely follow the reasoning behind ucx still being optional when it seems to only save ~20MB. The functionality is still optional, right?

[leofang]

@conda-forge-admin, please rerender

[leofang]

No, not your fault at all. The rerendering functionality seems to be down at least today, which affects both offline rerendering and CI services. The core team is investigating: conda-forge/conda-forge-ci-setup-feedstock#350 (comment).

To close the loop, it turns out the rerendering failed for another reason: #177 (comment) which is now fixed.

[leofang]

I don't entirely follow the reasoning behind ucx still being optional when it seems to only save ~20MB. The functionality is still optional, right?

My preference is if something is optional, we do not list them in run. In addition to extra bandwidth and storage usage, adding more dependencies could also run into dependency resolving issues (ex: #153). Right now this PR presents a minimal change to the recipe and I like it that way. Maybe we can move this discussion to a separate issue and try to get this merged once the last question on FCFLAG is resolved and the tests pass?

[minrk]

Makes sense!

[minrk]

Thanks, this LGTM now.

[minrk]

Doesn't need to happen here, but I think we can add actual tests that optional ucx works by including conda install ucc in run_test.sh, rather than purely inspecting the config output:

# first, test without ucx
# ...
conda install ucc ucx
# enable ucx, ucc
mpiexec -n 2 some_test
# verify ucx/ucc was used

[minrk]

Thanks @j34ni and thanks @leofang for reviewing!

[j34ni]

Thanks to you guys

…

________________________________ From: Min RK ***@***.***> Sent: Friday, September 27, 2024 13:30 To: conda-forge/openmpi-feedstock ***@***.***> Cc: Jean Iaquinta ***@***.***>; Mention ***@***.***> Subject: Re: [conda-forge/openmpi-feedstock] Add UCC support (PR #175) Thanks @j34ni<https://github.com/j34ni> and thanks @leofang<https://github.com/leofang> for reviewing! — Reply to this email directly, view it on GitHub<#175 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKRWC36DEH6JSXHVPVTLIWLZYU6UDAVCNFSM6AAAAABOT2FC7KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZZGA3DCMJUHA>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[leofang]

Thanks @j34ni @minrk @pentschev!

[leofang]

FYI as a follow-up I'm adding UCC to the global pinning conda-forge/conda-forge-pinning-feedstock#6484

[leofang]

Maybe we can move this discussion to a separate issue

See #181.