Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: rerender #177

Merged
merged 4 commits into from
Sep 26, 2024
Merged

Conversation

conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I've started rerendering the recipe as instructed in #176.

If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!

Here's a checklist to do before merging.

Fixes #176

Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the latest webservices GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or you can try rerendering locally.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/openmpi-feedstock/actions/runs/11044556333.

@leofang
Copy link
Member

leofang commented Sep 26, 2024

@conda-forge-admin, please rerender

Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the latest webservices GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or you can try rerendering locally.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/openmpi-feedstock/actions/runs/11052460942.

@leofang
Copy link
Member

leofang commented Sep 26, 2024

It seems the 2nd rerendering error (conda-forge/conda-forge-ci-setup-feedstock#350 (comment)) is still not fixed... 😛 cc @beckermr

@leofang
Copy link
Member

leofang commented Sep 26, 2024

@conda-forge-admin, please rerender

Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the latest webservices GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or you can try rerendering locally.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/openmpi-feedstock/actions/runs/11056211248.

@jakirkham
Copy link
Member

@conda-forge-admin, please re-render

Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the latest webservices GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or you can try rerendering locally.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/openmpi-feedstock/actions/runs/11058802354.

@jakirkham
Copy link
Member

@conda-forge-admin, please re-render

Starting with conda-build 24.7.0, undefined Jinja variables are handled
more strictly. So add guards around `CONDA_BUILD_SYSROOT` usage here.
Also ensure the tests error if `CONDA_BUILD_SYSROOT` is still undefined
at build time.
@jakirkham
Copy link
Member

@conda-forge-admin, please re-render

recipe/meta.yaml Outdated Show resolved Hide resolved
@jakirkham
Copy link
Member

@conda-forge-admin, please re-render

Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/openmpi-feedstock/actions/runs/11060122080.

@leofang
Copy link
Member

leofang commented Sep 26, 2024

@minrk would you mind taking a quick look before merging? I'd like to get this in asap to unblock #175.

@minrk
Copy link
Member

minrk commented Sep 26, 2024

Thanks! Yeah, I think this was a workaround for soemthing weird in old conda build, glad it's not needed anymore!

@minrk minrk merged commit fb069e1 into conda-forge:main Sep 26, 2024
10 checks passed
@leofang
Copy link
Member

leofang commented Sep 26, 2024

Thanks, @jakirkham @minrk!

@leofang leofang mentioned this pull request Sep 26, 2024
5 tasks
@jakirkham
Copy link
Member

Thanks Leo and Min! 🙏

Yeah it did look like something from either old conda-build or some earlier form of our build toolchain. Agree it is nice to see this is no longer needed 😌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@conda-forge-admin , please re-render
4 participants