-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default build tool to conda-build again #1844
Change default build tool to conda-build again #1844
Conversation
Signed-off-by: Marcel Bargull <marcel.bargull@udo.edu>
Signed-off-by: Marcel Bargull <marcel.bargull@udo.edu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am for this, but we need to put a pin somewhere to ensure the latest version is used. There were some bugs which is why re rolled this back last I checked.
I guess shove a
#1805 |
Yes I think so or we can have it as a constraint on our ci setup package. |
Not against this change, but just wanted to note that we could also (try to) backport the fix for mamba-org/boa#392 to unblock that constraint. |
Are we guaranteed to get the latest If not, maybe adding it here is easiest (though no objections to doing both) |
Yeah let's add it here. Good idea! |
Signed-off-by: Marcel Bargull <marcel.bargull@udo.edu>
Conceptually, I think |
I agree. What's nice here is that people can override easily. |
Thanks all! 🙏 Should we make a new release ( #1845 )? |
Thanks for the reviews! |
Checklist
news
entryI'd like us to get the fixes from
conda-build=24.1.2
in which also affectconda-build=3.28.4
which we are currently limited to due to conda-forge/conda-forge-repodata-patches-feedstock#657 / mamba-org/boa#392 .If we change to
conda-build
by default, we can avoid the constraint needed forboa=0.16.0
.(We should also put out a
boa=0.16.1
for feedstocks that haveconda-mambabuild
set explicitly, of course.)