Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default build tool to conda-build again #1844

Merged
merged 3 commits into from
Feb 21, 2024

Conversation

mbargull
Copy link
Member

@mbargull mbargull commented Feb 20, 2024

Checklist

  • Added a news entry

I'd like us to get the fixes from conda-build=24.1.2 in which also affect conda-build=3.28.4 which we are currently limited to due to conda-forge/conda-forge-repodata-patches-feedstock#657 / mamba-org/boa#392 .
If we change to conda-build by default, we can avoid the constraint needed for boa=0.16.0.
(We should also put out a boa=0.16.1 for feedstocks that have conda-mambabuild set explicitly, of course.)

Signed-off-by: Marcel Bargull <marcel.bargull@udo.edu>
Signed-off-by: Marcel Bargull <marcel.bargull@udo.edu>
@mbargull mbargull marked this pull request as ready for review February 20, 2024 16:53
@mbargull mbargull requested a review from a team as a code owner February 20, 2024 16:53
Copy link
Member

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am for this, but we need to put a pin somewhere to ensure the latest version is used. There were some bugs which is why re rolled this back last I checked.

@mbargull
Copy link
Member Author

I am for this, but we need to put a pin somewhere to ensure the latest version is used.

I guess shove a conda-build>=24.1 into remote_ci_setup so that the user can override it when needed, right?

There were some bugs which is why re rolled this back last I checked.

#1805
Yep, there were some oddities with conda-build using legacy code paths such that it didn't play well with conda-libmamba-solver; we've added some changes to conda/conda-libmamba-solver in November to fix that.

@beckermr
Copy link
Member

Yes I think so or we can have it as a constraint on our ci setup package.

@h-vetinari
Copy link
Member

If we change to conda-build by default, we can avoid the constraint needed for boa=0.16.0.

Not against this change, but just wanted to note that we could also (try to) backport the fix for mamba-org/boa#392 to unblock that constraint.

@jakirkham
Copy link
Member

Yes I think so or we can have it as a constraint on our ci setup package.

Are we guaranteed to get the latest conda-forge-ci-setup when installing?

If not, maybe adding it here is easiest (though no objections to doing both)

@beckermr
Copy link
Member

Yeah let's add it here. Good idea!

Signed-off-by: Marcel Bargull <marcel.bargull@udo.edu>
@mbargull
Copy link
Member Author

Conceptually, I think conda-forge-ci-setup would be a nicer place for it (yes, we'd need to then have conda-forge-ci-setup=4,>={version with lower bound on conda-build} in remote_ci_setup here then), but for now, I'd also guess it's fine to add it here (done in the latest commit) and would postpone conceptual discussion currently.

@beckermr
Copy link
Member

I agree. What's nice here is that people can override easily.

@beckermr beckermr merged commit 15ea0a3 into conda-forge:main Feb 21, 2024
2 checks passed
@jakirkham
Copy link
Member

Thanks all! 🙏

Should we make a new release ( #1845 )?

@mbargull
Copy link
Member Author

Thanks for the reviews!

@h-vetinari
Copy link
Member

Should we make a new release ( #1845 )?

Give me a short time to make a minimal PR for #1840 please (just adding the comprehension for stdlib jinjas), so that - ideally - we won't have to release separately for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants