Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: rerender and enable windows tests #38

Merged
merged 14 commits into from
May 19, 2023

Conversation

conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I've started rerendering the recipe as instructed in #37.

If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!

Here's a checklist to do before merging.

  • Bump the build number if needed.

Fixes #37

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

conda-forge-webservices[bot] and others added 3 commits May 18, 2023 11:58
@traversaro traversaro changed the title MNT: rerender MNT: rerender and ensure that Windows is build as shared May 18, 2023
@traversaro
Copy link
Contributor

Error:

[ 18%] Building CXX object dart/CMakeFiles/dart.dir/integration/EulerIntegrator.cpp.o
In file included from /home/conda/feedstock_root/build_artifacts/dartsim_1684411846598/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pla/include/eigen3/Eigen/Core:294,
                 from /home/conda/feedstock_root/build_artifacts/dartsim_1684411846598/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pla/include/eigen3/Eigen/Dense:1,
                 from /home/conda/feedstock_root/build_artifacts/dartsim_1684411846598/work/dart/math/Geometry.hpp:36,
                 from /home/conda/feedstock_root/build_artifacts/dartsim_1684411846598/work/dart/math/Geometry.cpp:33:
In constructor 'Eigen::PlainObjectBase<Derived>::PlainObjectBase(Eigen::PlainObjectBase<Derived>&&) [with Derived = Eigen::Matrix<double, 2, 1>]',
    inlined from 'Eigen::Matrix<_Scalar, _Rows, _Cols, _Options, _MaxRows, _MaxCols>::Matrix(Eigen::Matrix<_Scalar, _Rows, _Cols, _Options, _MaxRows, _MaxCols>&&) [with _Scalar = double; int _Rows = 2; int _Cols = 1; int _Options = 0; int _MaxRows = 2; int _MaxCols = 1]' at /home/conda/feedstock_root/build_artifacts/dartsim_1684411846598/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pla/include/eigen3/Eigen/src/Core/Matrix.h:274:30,
    inlined from 'Eigen::Vector2d dart::math::computeClosestPointOnSupportPolygon(std::size_t&, std::size_t&, const Eigen::Vector2d&, const SupportPolygon&)' at /home/conda/feedstock_root/build_artifacts/dartsim_1684411846598/work/dart/math/Geometry.cpp:2096:10:
/home/conda/feedstock_root/build_artifacts/dartsim_1684411846598/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pla/include/eigen3/Eigen/src/Core/PlainObjectBase.h:496:9: error: '*(__m128d*)((char*)&result + offsetof(Eigen::Vector2d, Eigen::Matrix<double, 2, 1, 0, 2, 1>::<unnamed>.Eigen::PlainObjectBase<Eigen::Matrix<double, 2, 1, 0, 2, 1> >::<unnamed>.Eigen::MatrixBase<Eigen::Matrix<double, 2, 1, 0, 2, 1> >::<unnamed>.Eigen::DenseBase<Eigen::Matrix<double, 2, 1, 0, 2, 1> >::<unnamed>.Eigen::DenseCoeffsBase<Eigen::Matrix<double, 2, 1, 0, 2, 1>, 3>::<unnamed>.Eigen::DenseCoeffsBase<Eigen::Matrix<double, 2, 1, 0, 2, 1>, 1>::<unnamed>.Eigen::DenseCoeffsBase<Eigen::Matrix<double, 2, 1, 0, 2, 1>, 0>::<unnamed>))' may be used uninitialized [-Werror=maybe-uninitialized]
  496 |       : m_storage( std::move(other.m_storage) )
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/conda/feedstock_root/build_artifacts/dartsim_1684411846598/work/dart/math/Geometry.cpp: In function 'Eigen::Vector2d dart::math::computeClosestPointOnSupportPolygon(std::size_t&, std::size_t&, const Eigen::Vector2d&, const SupportPolygon&)':
/home/conda/feedstock_root/build_artifacts/dartsim_1684411846598/work/dart/math/Geometry.cpp:2079:25: note: '*(__m128d*)((char*)&result + offsetof(Eigen::Vector2d, Eigen::Matrix<double, 2, 1, 0, 2, 1>::<unnamed>.Eigen::PlainObjectBase<Eigen::Matrix<double, 2, 1, 0, 2, 1> >::<unnamed>.Eigen::MatrixBase<Eigen::Matrix<double, 2, 1, 0, 2, 1> >::<unnamed>.Eigen::DenseBase<Eigen::Matrix<double, 2, 1, 0, 2, 1> >::<unnamed>.Eigen::DenseCoeffsBase<Eigen::Matrix<double, 2, 1, 0, 2, 1>, 3>::<unnamed>.Eigen::DenseCoeffsBase<Eigen::Matrix<double, 2, 1, 0, 2, 1>, 1>::<unnamed>.Eigen::DenseCoeffsBase<Eigen::Matrix<double, 2, 1, 0, 2, 1>, 0>::<unnamed>))' was declared here
 2079 |   Eigen::Vector2d test, result;
      |                         ^~~~~~
cc1plus: all warnings being treated as errors

We need to disable warning as errors.

@traversaro
Copy link
Contributor

Windows fails:

%PREFIX%\Library\include\eigen3\Eigen\src/Core/DenseBase.h(43): fatal error C1060: compiler is out of heap space

we probably need again to reduce the number of threads.

@traversaro traversaro changed the title MNT: rerender and ensure that Windows is build as shared MNT: rerender and enable windows tests May 19, 2023
@traversaro traversaro closed this May 19, 2023
@traversaro traversaro reopened this May 19, 2023
@traversaro
Copy link
Contributor

It just fails test_Collision on Windows, I think we can suppress the test and proceed.

@traversaro
Copy link
Contributor

It just fails test_Collision on Windows, I think we can suppress the test and proceed.

Apparently test_Collision is already supressed in Linux/macOS : https://github.com/conda-forge/dartsim-feedstock/blob/c765f62e877c61def00fdd47f99f8f319ad567f1/recipe/build.sh#LL35C33-L35C47 .

@traversaro traversaro merged commit fc66e60 into conda-forge:main May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@conda-forge-admin, please rerender
2 participants