Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 3.3.0 #26

Merged
merged 4 commits into from
Oct 28, 2024
Merged

Release 3.3.0 #26

merged 4 commits into from
Oct 28, 2024

Conversation

Tieqiong
Copy link
Contributor

@Tieqiong Tieqiong commented Oct 27, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@Tieqiong
Copy link
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.
I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@sbillinge
Copy link
Contributor

@Tieqiong please check, I think we may need to change the python versions in the meta.yaml.

@Tieqiong
Copy link
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

  • Recipe maintainer "bobleesj" does not exist
  • Recipe maintainer "dragonyanglong" does not exist
  • Recipe maintainer "pavoljuhas" does not exist
  • Recipe maintainer "st3107" does not exist
  • Recipe maintainer "sbillinge" does not exist

For recipe/meta.yaml:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.
I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@sbillinge sbillinge merged commit aa5e267 into conda-forge:main Oct 28, 2024
1 check passed
@Tieqiong
Copy link
Contributor Author

@sbillinge For some reason the Azure pipeline check was not run, and I believe it's also happening for diffpy.utils. We might not be able to release to conda-forge before figuring this out...

@sbillinge
Copy link
Contributor

Ah, o missed that in this case. Yes, let's not merge any more until we sort this out

@bobleesj
Copy link
Contributor

Screenshot 2024-10-28 at 10 28 18 PM

@Tieqiong @sbillinge Just wanted to share our merged CI failed, hence 3.3.0 isn't available on conda-forge: https://anaconda.org/conda-forge/diffpy.structure/files

@Tieqiong
Copy link
Contributor Author

@bobleesj where were you able to see the checks?

@bobleesj
Copy link
Contributor

Screenshot 2024-10-28 at 10 33 59 PM

in the main repo

@Tieqiong
Copy link
Contributor Author

@bobleesj It seems like nothing was actually run. they all stop at very early stage in a few seconds. Were you able to run Azure pipeline in other feedstocks PRs?

@bobleesj
Copy link
Contributor

Oddly, yes https://github.com/conda-forge/diffpy.labpdfproc-feedstock - it does not have the permission problem like here.

In diffpy.utils-feedstock, I've tagged admins for help.

@bobleesj
Copy link
Contributor

@Tieqiong CI running again - git commit --allow-empty -m "push empty, re-run CI" worked

conda-forge/diffpy.utils-feedstock#39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants