Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 3.5.0, support py313 #39

Merged
merged 6 commits into from
Oct 29, 2024
Merged

Release 3.5.0, support py313 #39

merged 6 commits into from
Oct 29, 2024

Conversation

bobleesj
Copy link
Contributor

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@bobleesj
Copy link
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.
I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@bobleesj
Copy link
Contributor Author

@sbillinge very odd that linux CI isn't running - not ready to be merged.

@bobleesj
Copy link
Contributor Author

@conda-forge-admin, please rerender

let's re-render to see whether CI can appear.

@bobleesj
Copy link
Contributor Author

@conda-forge-admin @xhochy

It appears that no Linux CI is currently appearing in this PR, even though we have seen it in other feedstocks that follow the same meta.yaml format. Please see this link: conda-forge/diffpy.srmise-feedstock#5.

Could you please provide guidance on how to run the Linux build CI again?

@bobleesj
Copy link
Contributor Author

@conda-forge-admin, please rerender

@bobleesj
Copy link
Contributor Author

@ocefpaf Could you please provide insight into why Linux CI isn't automatically running for this PR? We're also noticing Linux CI not executing in three other feedstocks as well.

@ocefpaf
Copy link
Member

ocefpaf commented Oct 29, 2024

See conda-forge/status#188

@bobleesj
Copy link
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11573966257.

@bobleesj
Copy link
Contributor Author

@ocefpaf Thanks! seems like CI is running again. Appreciate your support as always.

@bobleesj
Copy link
Contributor Author

@sbillinge ready to be merged - will release pdfmoprh as well after testing diffpy.utils py313 support.

@sbillinge sbillinge merged commit d8f2a22 into conda-forge:main Oct 29, 2024
4 checks passed
@sbillinge
Copy link
Contributor

@bobleesj thanks, done. Do I have to also redo diffpy.structure?

@bobleesj bobleesj deleted the 3.5.0 branch October 29, 2024 22:11
@bobleesj
Copy link
Contributor Author

yes, will make a comment in diffpy.structure-feedstock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants