Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactivate windows #119

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

Conversation

zklaus
Copy link

@zklaus zklaus commented Aug 28, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

closes #115

With updated compilers in the m2 stack available, we might just be able to pull this off without a migration to flang.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@zklaus zklaus force-pushed the reactivate-windows branch from 57d7432 to 8ccee75 Compare August 29, 2024 07:24
@zklaus
Copy link
Author

zklaus commented Aug 29, 2024

Will need conda-forge/netcdf-fortran-feedstock#89, maybe more.

Comment on lines 1 to 17
m2w64_c_compiler: # [win]
- gcc # [win]
m2w64_c_compiler_version: # [win]
- 13 # [win]
m2w64_cxx_compiler: # [win]
- gxx # [win]
m2w64_cxx_compiler_version: # [win]
- 13 # [win]
m2w64_fortran_compiler: # [win]
- gfortran # [win]
m2w64_fortran_compiler_version: # [win]
- 13 # [win]
m2w64_c_stdlib: # [win]
- m2w64-sysroot # [win]
m2w64_c_stdlib_version: # [win]
- 12 # [win]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should copy the migrator file instead of editing like this

@xylar
Copy link
Contributor

xylar commented Aug 29, 2024

@zklaus, it seems like we should switch to using a migrator in netcdf-fortran as well, following @isuruf's suggestion above. I wasn't aware of the migrator.

@zklaus
Copy link
Author

zklaus commented Aug 30, 2024

These efforts predate my awareness of the applicability of the migrator to this feedstock. But yeah, let me give that a try.

@zklaus zklaus force-pushed the reactivate-windows branch from bddc051 to f6dc72c Compare August 30, 2024 08:29
@zklaus zklaus marked this pull request as ready for review August 30, 2024 10:16
@zklaus zklaus marked this pull request as draft August 30, 2024 10:16
@zklaus
Copy link
Author

zklaus commented Aug 30, 2024

Sorry, this is not ready for review. Just a bad click.

@zklaus
Copy link
Author

zklaus commented Sep 10, 2024

@conda-forge-admin, please rerender

@zklaus
Copy link
Author

zklaus commented Oct 3, 2024

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@xylar xylar mentioned this pull request Oct 8, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why is v8.6.x not built for Windows ?
4 participants