-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate documentation with Windows #196
Conversation
… test the batch file
I can't seem to install a working environment for
The good news is that it seems as though there's recent work to finally port the latest Unless I can get access to a Windows machine with an environment configuration that works, this PR is blocked for now. |
The issue was importlib-metadata complaining about the metadata in @RondeauG and/or @sebastienlanglois, can you try running this script in your respective Windows environments SVP ? |
@@ -8,6 +8,7 @@ dependencies: | |||
- cartopy | |||
- geopandas | |||
- haversine | |||
- importlib-metadata <8.0 # Required for xesmf >=8.4.0,<8.6 to work on Windows |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a danger to pin this for everyone?
Also, I don't know exactly why this is required for it to work on GitHub, but my local setup works with importlib-metadata 8.4.0, esmpy 8.4.2, xesmf 0.8.7
without any issue...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I grabbed this fix from here: CLIMADA-project/climada_petals#132.
I don't think it is dangerous, but from my understanding, the fact that the metadata is corrupted in esmpy
/esmf
, we need to have an older version here, otherwise this raises ValueErrors
on import.
Pull Request Checklist:
number
) and pull request (:pull:number
) has been added.What kind of change does this PR introduce?
Does this PR introduce a breaking change?
No.
Other information:
The final accepted PR should not include a workflow. This tool should be available for local execution by Windows users.
My assumptions for Windows users are:
nmake
is not available (nomake
utilities)gitbash
are not available (noBASH
shell)