update to 14.1 + aarch64 #69
Conversation
…nda-forge-pinning 2023.12.02.17.06.41
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
There was a problem hiding this comment.
Hi @matthiasdiener, thanks for the PR! I left a few questions below.
recipe/meta.yaml
Outdated
| @@ -47,7 +47,7 @@ requirements: | |||
|
|
|||
| test: | |||
| commands: | |||
| - gdb --version | |||
| - $PREFIX/bin/gdb --version | |||
There was a problem hiding this comment.
is this needed because gdb is installed in the aarch64 image ? If so, can we mention it in the commit message ?
There was a problem hiding this comment.
This change was just for debugging, I undid it in 5b53248
| #!/usr/bin/env bash -ex | ||
| #!/bin/bash | ||
|
|
||
| set -ex |
There was a problem hiding this comment.
is this change needed ? if so, please mention why in the commit message.
There was a problem hiding this comment.
This change isn't really needed, I just did it to make the file follow the same header structure as build.sh.
matthiasdiener
requested review from
gqmelo and
marcelotrevisani
as code owners
|
This is ready for review. I added myself to the list of maintainers, I hope that's ok. |
|
Thank you! It did add me automatically to the automation as far as I can see. |
|
2 of the Travis CI jobs died during the build on |
|
One Travis CI job still died. Restarted again Might be worth looking into cross-compilation for a more robust solution |
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)