Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to 14.1 + aarch64 #69

Merged
merged 5 commits into from
Feb 13, 2024
Merged

update to 14.1 + aarch64 #69

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
de833dc
updated v14.1
regro-cf-autotick-bot Dec 3, 2023
fd676de
MNT: Re-rendered with conda-build 3.27.0, conda-smithy 3.30.1, and co…
regro-cf-autotick-bot Dec 3, 2023
1af5924
rerender + aarch64
matthiasdiener Feb 12, 2024
d9e1c3c
disable test on aarch64
matthiasdiener Feb 12, 2024
5b53248
rever unnecessary change
matthiasdiener Feb 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion recipe/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ requirements:

test:
commands:
- gdb --version
- $PREFIX/bin/gdb --version
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this needed because gdb is installed in the aarch64 image ? If so, can we mention it in the commit message ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was just for debugging, I undid it in 5b53248

requires:
- {{ compiler('c') }}

Expand Down
8 changes: 5 additions & 3 deletions recipe/run_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
#!/usr/bin/env bash -ex
#!/bin/bash

set -ex
Comment on lines -1 to +3
Copy link
Contributor

@phil-blain phil-blain Feb 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this change needed ? if so, please mention why in the commit message.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change isn't really needed, I just did it to make the file follow the same header structure as build.sh.


# Make sure we are not prompted for a password before running an executable in GDB on macOS
if [[ $(uname) == "Darwin" ]]; then
Expand Down Expand Up @@ -42,8 +44,8 @@ if [[ $(uname) == "Darwin" ]]; then
exit 0
fi

if [[ $(uname -m) == "ppc64le" ]]; then
# Skip Python test on ppc64le due to missing debug symbols
if [[ $(uname -m) == "ppc64le" || $(uname -m) == "aarch64" ]]; then
# Skip Python test on ppc64le/aarch64 due to missing debug symbols
exit 0
fi

Expand Down