[1.47] shared abseil on windows + test overhaul #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-vetinari
requested review from
mariusvniekerk,
pitrou,
wesm and
xhochy
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
h-vetinari
force-pushed
the
cxx17_1.47
branch
from
2e5c5a4 to
963b778
Compare
To keep some sanity while all these migrations are still ongoing. Need to trick conda smithy as follows, c.f. conda-forge#236 (comment) ``` diff --git a/.ci_support/migrations/libprotobuf321.yaml b/.ci_support/migrations/libprotobuf321.yaml deleted file mode 100644 index 41701fa..0000000 --- a/.ci_support/migrations/libprotobuf321.yaml +++ /dev/null @@ -1,7 +0,0 @@ -__migrator: - build_number: 1 - kind: version - migration_number: 1 -libprotobuf: -- '3.21' -migrator_ts: 1661531047.2553904 diff --git a/recipe/conda_build_config.yaml b/recipe/conda_build_config.yaml index 81df92e..b022bac 100644 --- a/recipe/conda_build_config.yaml +++ b/recipe/conda_build_config.yaml @@ -2,3 +2,7 @@ c_compiler_version: # [linux] - '11' # [linux] cxx_compiler_version: # [linux] - '11' # [linux] +libprotobuf: +- '3.20' +- '3.21' ``` and then rerender: MNT: Re-rendered with conda-build 3.22.0, conda-smithy 3.21.1, and conda-forge-pinning 2022.09.04.11.55.37
h-vetinari
force-pushed
the
cxx17_1.47
branch
from
963b778 to
a05ef10
Compare
|
I'm taking the review of the effectively equivalent #239 as reason enough to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #239